Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1725519 > unrolled thread

[PATCH 0/7] [media] OmniVision: Adjustments for four function implementations

Started bySF Markus Elfring <elfring@users.sourceforge.net>
First post2017-09-02 17:50 +0200
Last post2017-09-02 18:00 +0200
Articles 6 — 1 participant

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/7] [media] OmniVision: Adjustments for four function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 17:50 +0200
    [PATCH 5/7] [media] ov9640: Improve a size determination in  ov9640_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 18:00 +0200
    [PATCH 3/7] [media] ov6650: Delete an error message for a failed  memory allocation in ov6650_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 18:00 +0200
    [PATCH 6/7] [media] ov9740: Delete an error message for a failed  memory allocation in ov9740_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 18:00 +0200
    [PATCH 4/7] [media] ov9640: Delete an error message for a failed  memory allocation in ov9640_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 18:00 +0200
    [PATCH 7/7] [media] ov9740: Improve a size determination in  ov9740_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 18:00 +0200

#1725519 — [PATCH 0/7] [media] OmniVision: Adjustments for four function implementations

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2017-09-02 17:50 +0200
Subject[PATCH 0/7] [media] OmniVision: Adjustments for four function implementations
Message-ID<uliQh-4Hk-5@gated-at.bofh.it>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 2 Sep 2017 17:01:23 +0200

A few update suggestions were taken into account
from static source code analysis.

Markus Elfring (7):
  Delete an error message for a failed memory allocation in ov2640_probe()
  Improve a size determination in ov2640_probe()
  Delete an error message for a failed memory allocation in ov6650_probe()
  Delete an error message for a failed memory allocation in ov9640_probe()
  Improve a size determination in ov9640_probe()
  Delete an error message for a failed memory allocation in ov9740_probe()
  Improve a size determination in ov9740_probe()

 drivers/media/i2c/ov2640.c            | 7 ++-----
 drivers/media/i2c/ov6650.c            | 5 +----
 drivers/media/i2c/soc_camera/ov9640.c | 7 ++-----
 drivers/media/i2c/soc_camera/ov9740.c | 6 ++----
 4 files changed, 7 insertions(+), 18 deletions(-)

-- 
2.14.1

[toc] | [next] | [standalone]

#1725520 — [PATCH 5/7] [media] ov9640: Improve a size determination in ov9640_probe()

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2017-09-02 18:00 +0200
Subject[PATCH 5/7] [media] ov9640: Improve a size determination in ov9640_probe()
Message-ID<uliZX-4Mu-3@gated-at.bofh.it>
In reply to#1725519
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 2 Sep 2017 16:37:03 +0200

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/i2c/soc_camera/ov9640.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/soc_camera/ov9640.c b/drivers/media/i2c/soc_camera/ov9640.c
index 0f02f022f3e9..67578f194928 100644
--- a/drivers/media/i2c/soc_camera/ov9640.c
+++ b/drivers/media/i2c/soc_camera/ov9640.c
@@ -675,5 +675,5 @@ static int ov9640_probe(struct i2c_client *client,
 		return -EINVAL;
 	}
 
-	priv = devm_kzalloc(&client->dev, sizeof(struct ov9640_priv), GFP_KERNEL);
+	priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
-- 
2.14.1

[toc] | [prev] | [next] | [standalone]

#1725522 — [PATCH 3/7] [media] ov6650: Delete an error message for a failed memory allocation in ov6650_probe()

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2017-09-02 18:00 +0200
Subject[PATCH 3/7] [media] ov6650: Delete an error message for a failed memory allocation in ov6650_probe()
Message-ID<uliZX-4Mu-9@gated-at.bofh.it>
In reply to#1725519
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 2 Sep 2017 16:16:39 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/i2c/ov6650.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/media/i2c/ov6650.c b/drivers/media/i2c/ov6650.c
index 768f2950ea36..8975d16b2b24 100644
--- a/drivers/media/i2c/ov6650.c
+++ b/drivers/media/i2c/ov6650.c
@@ -954,8 +954,5 @@ static int ov6650_probe(struct i2c_client *client,
-	if (!priv) {
-		dev_err(&client->dev,
-			"Failed to allocate memory for private data!\n");
+	if (!priv)
 		return -ENOMEM;
-	}
 
 	v4l2_i2c_subdev_init(&priv->subdev, client, &ov6650_subdev_ops);
 	v4l2_ctrl_handler_init(&priv->hdl, 13);
-- 
2.14.1

[toc] | [prev] | [next] | [standalone]

#1725524 — [PATCH 6/7] [media] ov9740: Delete an error message for a failed memory allocation in ov9740_probe()

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2017-09-02 18:00 +0200
Subject[PATCH 6/7] [media] ov9740: Delete an error message for a failed memory allocation in ov9740_probe()
Message-ID<uliZY-4Mu-17@gated-at.bofh.it>
In reply to#1725519
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 2 Sep 2017 16:44:36 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/i2c/soc_camera/ov9740.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/i2c/soc_camera/ov9740.c b/drivers/media/i2c/soc_camera/ov9740.c
index cc07b7ae5407..f44f5da795f9 100644
--- a/drivers/media/i2c/soc_camera/ov9740.c
+++ b/drivers/media/i2c/soc_camera/ov9740.c
@@ -939,7 +939,5 @@ static int ov9740_probe(struct i2c_client *client,
-	if (!priv) {
-		dev_err(&client->dev, "Failed to allocate private data!\n");
+	if (!priv)
 		return -ENOMEM;
-	}
 
 	v4l2_i2c_subdev_init(&priv->subdev, client, &ov9740_subdev_ops);
 	v4l2_ctrl_handler_init(&priv->hdl, 13);
-- 
2.14.1

[toc] | [prev] | [next] | [standalone]

#1725526 — [PATCH 4/7] [media] ov9640: Delete an error message for a failed memory allocation in ov9640_probe()

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2017-09-02 18:00 +0200
Subject[PATCH 4/7] [media] ov9640: Delete an error message for a failed memory allocation in ov9640_probe()
Message-ID<uliZY-4Mu-23@gated-at.bofh.it>
In reply to#1725519
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 2 Sep 2017 16:34:27 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/i2c/soc_camera/ov9640.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/media/i2c/soc_camera/ov9640.c b/drivers/media/i2c/soc_camera/ov9640.c
index 0146d1f7aacb..0f02f022f3e9 100644
--- a/drivers/media/i2c/soc_camera/ov9640.c
+++ b/drivers/media/i2c/soc_camera/ov9640.c
@@ -679,8 +679,5 @@ static int ov9640_probe(struct i2c_client *client,
-	if (!priv) {
-		dev_err(&client->dev,
-			"Failed to allocate memory for private data!\n");
+	if (!priv)
 		return -ENOMEM;
-	}
 
 	v4l2_i2c_subdev_init(&priv->subdev, client, &ov9640_subdev_ops);
 
-- 
2.14.1

[toc] | [prev] | [next] | [standalone]

#1725529 — [PATCH 7/7] [media] ov9740: Improve a size determination in ov9740_probe()

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2017-09-02 18:00 +0200
Subject[PATCH 7/7] [media] ov9740: Improve a size determination in ov9740_probe()
Message-ID<uliZY-4Mu-27@gated-at.bofh.it>
In reply to#1725519
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 2 Sep 2017 16:46:03 +0200

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/i2c/soc_camera/ov9740.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/soc_camera/ov9740.c b/drivers/media/i2c/soc_camera/ov9740.c
index f44f5da795f9..755de2289c39 100644
--- a/drivers/media/i2c/soc_camera/ov9740.c
+++ b/drivers/media/i2c/soc_camera/ov9740.c
@@ -935,5 +935,5 @@ static int ov9740_probe(struct i2c_client *client,
 		return -EINVAL;
 	}
 
-	priv = devm_kzalloc(&client->dev, sizeof(struct ov9740_priv), GFP_KERNEL);
+	priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
-- 
2.14.1

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web