Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1725483
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 07/11] extcon: intel-int3496: Add support for controlling the USB-role mux |
| Date | 2017-09-02 12:40 +0200 |
| Message-ID | <ule0h-1NH-13@gated-at.bofh.it> (permalink) |
| References | <ul1Z7-2jb-7@gated-at.bofh.it> <ul1Z8-2jb-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Sep 2, 2017 at 12:48 AM, Hans de Goede <hdegoede@redhat.com> wrote:
> Cherry Trail SoCs have a built-in USB-role mux for switching between
> the host and device controllers, rather then using an external mux
> controller by a GPIO.
>
> There is a driver using the mux-subsys to control this mux, this
> commit adds support to the intel-int3496 driver to get a mux_controller
> handle for the mux and set the mux through the mux-subsys rather then
> through a GPIO.
> tristate "Intel INT3496 ACPI device extcon driver"
> depends on GPIOLIB && ACPI && (X86 || COMPILE_TEST)
> + select MULTIPLEXER
> +#include <asm/cpu_device_id.h>
> +#include <asm/intel-family.h>
I think it is going to fail when !X86 && COMPILE_TEST.
> static void int3496_do_usb_id(struct work_struct *work)
> {
> struct int3496_data *data =
> container_of(work, struct int3496_data, work.work);
> - int id = gpiod_get_value_cansleep(data->gpio_usb_id);
> + int ret, id = gpiod_get_value_cansleep(data->gpio_usb_id);
Better to keep them on separate lines.
--
With Best Regards,
Andy Shevchenko
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/11] mux/typec: Add USB / TypeC mux drivers and hook them up on some x86 systems Hans de Goede <hdegoede@redhat.com> - 2017-09-01 23:50 +0200
[PATCH 03/11] mux: consumer.h: Add MUX_USB_* state constant defines Hans de Goede <hdegoede@redhat.com> - 2017-09-01 23:50 +0200
Re: [PATCH 03/11] mux: consumer.h: Add MUX_USB_* state constant defines Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-09-02 12:20 +0200
Re: [PATCH 03/11] mux: consumer.h: Add MUX_USB_* state constant defines Hans de Goede <hdegoede@redhat.com> - 2017-09-02 14:10 +0200
Re: [PATCH 03/11] mux: consumer.h: Add MUX_USB_* state constant defines Guenter Roeck <linux@roeck-us.net> - 2017-09-02 17:10 +0200
Re: [PATCH 03/11] mux: consumer.h: Add MUX_USB_* state constant defines Hans de Goede <hdegoede@redhat.com> - 2017-09-02 18:00 +0200
Re: [PATCH 03/11] mux: consumer.h: Add MUX_USB_* state constant defines Guenter Roeck <linux@roeck-us.net> - 2017-09-02 21:10 +0200
Re: [PATCH 03/11] mux: consumer.h: Add MUX_USB_* state constant defines Hans de Goede <hdegoede@redhat.com> - 2017-09-02 21:50 +0200
[PATCH 08/11] staging: typec: tcpm: Set mux to device mode when configured as such Hans de Goede <hdegoede@redhat.com> - 2017-09-01 23:50 +0200
[PATCH 07/11] extcon: intel-int3496: Add support for controlling the USB-role mux Hans de Goede <hdegoede@redhat.com> - 2017-09-01 23:50 +0200
Re: [PATCH 07/11] extcon: intel-int3496: Add support for controlling the USB-role mux Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-09-02 12:40 +0200
Re: [PATCH 07/11] extcon: intel-int3496: Add support for controlling the USB-role mux Hans de Goede <hdegoede@redhat.com> - 2017-09-04 16:20 +0200
[PATCH 10/11] staging: typec: fusb302: Hook up mux support using tcpc_gen_mux support Hans de Goede <hdegoede@redhat.com> - 2017-09-01 23:50 +0200
[PATCH 01/11] mux: core: Add of_mux_control_get helper function Hans de Goede <hdegoede@redhat.com> - 2017-09-01 23:50 +0200
[PATCH 09/11] staging: typec: Add Generic TCPC mux driver using the mux subsys Hans de Goede <hdegoede@redhat.com> - 2017-09-02 00:00 +0200
[PATCH 04/11] usb: xhci: Add Intel cherrytrail extended cap / otg phy mux handling Hans de Goede <hdegoede@redhat.com> - 2017-09-02 00:00 +0200
Re: [PATCH 04/11] usb: xhci: Add Intel cherrytrail extended cap / otg phy mux handling Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2017-09-04 09:40 +0200
Re: [PATCH 04/11] usb: xhci: Add Intel cherrytrail extended cap / otg phy mux handling Hans de Goede <hdegoede@redhat.com> - 2017-09-05 12:10 +0200
[PATCH 06/11] mux: Add Pericom PI3USB30532 Type-C mux driver Hans de Goede <hdegoede@redhat.com> - 2017-09-02 00:00 +0200
[PATCH 02/11] mux: core: Add support for getting a mux controller on a non DT platform Hans de Goede <hdegoede@redhat.com> - 2017-09-02 00:00 +0200
Re: [PATCH 02/11] mux: core: Add support for getting a mux controller on a non DT platform sathya <sathyaosid@gmail.com> - 2017-09-02 21:20 +0200
Re: [PATCH 02/11] mux: core: Add support for getting a mux controller on a non DT platform Hans de Goede <hdegoede@redhat.com> - 2017-09-04 16:30 +0200
Re: [PATCH 02/11] mux: core: Add support for getting a mux controller on a non DT platform Hans de Goede <hdegoede@redhat.com> - 2017-09-05 13:00 +0200
Re: [PATCH 00/11] mux/typec: Add USB / TypeC mux drivers and hook them up on some x86 systems Hans de Goede <hdegoede@redhat.com> - 2017-09-05 13:00 +0200
csiph-web