Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1725484

Re: [PATCH] locking/refcounts, x86/asm: Use unique .text section for refcount exceptions

Show all headers | View raw

* Kees Cook <keescook@chromium.org> wrote:

> Using .text.unlikely for refcount exceptions isn't safe because gcc may
> move entire functions into .text.unlikely (e.g. in6_dev_get()), which
> would cause any uses of a protected refcount_t function to stay inline
> with the function, triggering the protection unconditionally:
> 
>         .section        .text.unlikely,"ax",@progbits
>         .type   in6_dev_get, @function
> in6_dev_getx:
> .LFB4673:
>         .loc 2 4128 0
>         .cfi_startproc
> ...
>         lock; incl 480(%rbx)
>         js 111f
>         .pushsection .text.unlikely
> 111:    lea 480(%rbx), %rcx
> 112:    .byte 0x0f, 0xff
> .popsection
> 113:
> 
> This creates a unique .text section and adds an additional test to the
> exception handler to WARN in the case of having none of OF, SF, nor ZF
> set so we can see things like this more easily in the future.
> 
> Reported-by: Mike Galbraith <efault@gmx.de>
> Fixes: 7a46ec0e2f48 ("locking/refcounts, x86/asm: Implement fast refcount overflow protection")
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  arch/x86/Kconfig                  | 2 +-
>  arch/x86/include/asm/refcount.h   | 2 +-
>  arch/x86/mm/extable.c             | 7 ++++++-
>  include/asm-generic/vmlinux.lds.h | 1 +
>  4 files changed, 9 insertions(+), 3 deletions(-)

Could you please split this into two patches: one that fixes the .unlikely bug, 
the other that re-enables the optimized version?

Should there be any other problem with refcounts this would make any bisection 
result more clear-cut.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] locking/refcounts, x86/asm: Use unique .text section for  refcount exceptions Kees Cook <keescook@chromium.org> - 2017-09-01 22:30 +0200
  Re: [PATCH] locking/refcounts, x86/asm: Use unique .text section for  refcount exceptions Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-09-01 23:50 +0200
    Re: [PATCH] locking/refcounts, x86/asm: Use unique .text section for  refcount exceptions Kees Cook <keescook@chromium.org> - 2017-09-02 05:00 +0200
      Re: [PATCH] locking/refcounts, x86/asm: Use unique .text section for  refcount exceptions Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-09-02 10:20 +0200
  Re: [PATCH] locking/refcounts, x86/asm: Use unique .text section  for refcount exceptions Mike Galbraith <efault@gmx.de> - 2017-09-02 06:10 +0200
    Re: [PATCH] locking/refcounts, x86/asm: Use unique .text section for  refcount exceptions Kees Cook <keescook@chromium.org> - 2017-09-02 09:40 +0200
  Re: [PATCH] locking/refcounts, x86/asm: Use unique .text section for  refcount exceptions Ingo Molnar <mingo@kernel.org> - 2017-09-02 12:40 +0200
    Re: [PATCH] locking/refcounts, x86/asm: Use unique .text section for  refcount exceptions Kees Cook <keescook@chromium.org> - 2017-09-02 22:00 +0200

csiph-web