Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1725492

Re: [PATCH 03/11] mux: consumer.h: Add MUX_USB_* state constant defines

Show all headers | View raw

Hi,

On 02-09-17 12:10, Andy Shevchenko wrote:
> On Sat, Sep 2, 2017 at 12:48 AM, Hans de Goede <hdegoede@redhat.com> wrote:
>> Add MUX_USB_* state constant defines, which can be used by USB
>> device/host and Type-C polarity/role/altmode mux drivers and consumers
>> to ensure that they agree on the meaning of the mux_control_select()
>> state argument.
> 
>> +/*
>> + * Mux state values for USB muxes, used for both USB device/host role muxes
>> + * as well as for Type-C polarity/role/altmode muxes.
>> + *
>> + * MUX_USB_POLARITY_INV may be or-ed together with any other mux-state as
>> + * inverted-polarity (Type-C plugged in upside down) can happen with any
>> + * other mux-state.
>> + */
>> +#define MUX_USB_POLARITY_INV   BIT(0)   /* Polarity inverted bit */
>> +#define MUX_USB_NONE           (1 << 1) /* Mux open / not connected */
>> +#define MUX_USB_DEVICE         (2 << 1) /* USB device mode */
>> +#define MUX_USB_HOST           (3 << 1) /* USB host mode */
>> +#define MUX_USB_HOST_AND_DP_SRC        (4 << 1) /* USB host + 2 lanes Display Port */
>> +#define MUX_USB_DP_SRC         (5 << 1) /* 4 lanes Display Port source */
>> +#define MUX_USB_STATES         (6 << 1)
> 
> I would put OR'ed bits higher.
> 
> Like allocate 4 (8) bits for states and start special flags from bit
> 8 and so on.

That is not an option because the mux framework expects a mux to declare
how much states it has (which is where the MUX_USB_STATES define comes in)
and any attemp to set a state higher then max_states will return with
-EINVAL.

Regards,

Hans

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/11] mux/typec: Add USB / TypeC mux drivers and hook them up on some x86 systems Hans de Goede <hdegoede@redhat.com> - 2017-09-01 23:50 +0200
  [PATCH 03/11] mux: consumer.h: Add MUX_USB_* state constant defines Hans de Goede <hdegoede@redhat.com> - 2017-09-01 23:50 +0200
    Re: [PATCH 03/11] mux: consumer.h: Add MUX_USB_* state constant defines Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-09-02 12:20 +0200
      Re: [PATCH 03/11] mux: consumer.h: Add MUX_USB_* state constant  defines Hans de Goede <hdegoede@redhat.com> - 2017-09-02 14:10 +0200
    Re: [PATCH 03/11] mux: consumer.h: Add MUX_USB_* state constant  defines Guenter Roeck <linux@roeck-us.net> - 2017-09-02 17:10 +0200
      Re: [PATCH 03/11] mux: consumer.h: Add MUX_USB_* state constant  defines Hans de Goede <hdegoede@redhat.com> - 2017-09-02 18:00 +0200
        Re: [PATCH 03/11] mux: consumer.h: Add MUX_USB_* state constant  defines Guenter Roeck <linux@roeck-us.net> - 2017-09-02 21:10 +0200
          Re: [PATCH 03/11] mux: consumer.h: Add MUX_USB_* state constant  defines Hans de Goede <hdegoede@redhat.com> - 2017-09-02 21:50 +0200
  [PATCH 08/11] staging: typec: tcpm: Set mux to device mode when configured as such Hans de Goede <hdegoede@redhat.com> - 2017-09-01 23:50 +0200
  [PATCH 07/11] extcon: intel-int3496: Add support for controlling the USB-role mux Hans de Goede <hdegoede@redhat.com> - 2017-09-01 23:50 +0200
    Re: [PATCH 07/11] extcon: intel-int3496: Add support for controlling  the USB-role mux Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-09-02 12:40 +0200
      Re: [PATCH 07/11] extcon: intel-int3496: Add support for controlling  the USB-role mux Hans de Goede <hdegoede@redhat.com> - 2017-09-04 16:20 +0200
  [PATCH 10/11] staging: typec: fusb302: Hook up mux support using tcpc_gen_mux support Hans de Goede <hdegoede@redhat.com> - 2017-09-01 23:50 +0200
  [PATCH 01/11] mux: core: Add of_mux_control_get helper function Hans de Goede <hdegoede@redhat.com> - 2017-09-01 23:50 +0200
  [PATCH 09/11] staging: typec: Add Generic TCPC mux driver using the mux subsys Hans de Goede <hdegoede@redhat.com> - 2017-09-02 00:00 +0200
  [PATCH 04/11] usb: xhci: Add Intel cherrytrail extended cap / otg phy mux handling Hans de Goede <hdegoede@redhat.com> - 2017-09-02 00:00 +0200
    Re: [PATCH 04/11] usb: xhci: Add Intel cherrytrail extended cap /  otg phy mux handling Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2017-09-04 09:40 +0200
      Re: [PATCH 04/11] usb: xhci: Add Intel cherrytrail extended cap / otg  phy mux handling Hans de Goede <hdegoede@redhat.com> - 2017-09-05 12:10 +0200
  [PATCH 06/11] mux: Add Pericom PI3USB30532 Type-C mux driver Hans de Goede <hdegoede@redhat.com> - 2017-09-02 00:00 +0200
  [PATCH 02/11] mux: core: Add support for getting a mux controller on a non DT platform Hans de Goede <hdegoede@redhat.com> - 2017-09-02 00:00 +0200
    Re: [PATCH 02/11] mux: core: Add support for getting a mux controller  on a non DT platform sathya <sathyaosid@gmail.com> - 2017-09-02 21:20 +0200
      Re: [PATCH 02/11] mux: core: Add support for getting a mux controller  on a non DT platform Hans de Goede <hdegoede@redhat.com> - 2017-09-04 16:30 +0200
    Re: [PATCH 02/11] mux: core: Add support for getting a mux controller  on a non DT platform Hans de Goede <hdegoede@redhat.com> - 2017-09-05 13:00 +0200
  Re: [PATCH 00/11] mux/typec: Add USB / TypeC mux drivers and hook  them up on some x86 systems Hans de Goede <hdegoede@redhat.com> - 2017-09-05 13:00 +0200

csiph-web