Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1723658

Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations

Show all headers | View raw

>>>> @@ -2363,5 +2364,5 @@ static int tsi148_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>>>>              master_num--;
>>>>
>>>>              tsi148_device->flush_image =
>>>> -                    kmalloc(sizeof(struct vme_master_resource), GFP_KERNEL);
>>>> +                    kmalloc(sizeof(*tsi148_device->flush_image), GFP_KERNEL);
>>>
>>> This line is now a tiny bit too long
>>
>> Can you eventually tolerate a line length of 81 characters at such a source code place?
>>
> 
> I think there's some irony here. On the one hand you are submitting
> patches that correct coding style issues, on the other you are asking
> whether we can ignore the coding style...

I test somehow how strict you would like to handle the length limit there.

I imagine that the affected source code formatting could also become different
if the involved variable name would be shorter.


>> * It seems that you would not like to perform such a tweak yourself.
> 
> To be honest, it is quicker and easier in this instance to do just that.

Interesting …


> So that's now done.

Thanks that you picked some of my ideas up.


> Patches now in my testing branch:
> 
> https://gitlab.collabora.com/martyn/linux/commits/vme-testing

I am curious on how the shown change possibilities will evolve from
this repository.


>> * Do you expect a resend for the complete patch series?
>>
> 
> Unless the maintainer has commented that they have accepted patches x,
> y and z, then sending the entire series again is generally the right
> thing to do.

Would you like to respond further to Greg's comments (from 2017-08-26)
for this patch series?

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/14] VME: Adjustments for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 17:50 +0200
  [PATCH 01/14] vme: Delete 11 error messages for a failed memory  allocation SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:00 +0200
  [PATCH 02/14] vme: Improve 11 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:00 +0200
  [PATCH 03/14] vme: Move an assignment in vme_new_dma_list() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:00 +0200
  [PATCH 04/14] vme: Adjust 48 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:00 +0200
  [PATCH 07/14] vme: fake: Improve five size determinations in  fake_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
  [PATCH 05/14] vme: Return directly in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
  [PATCH 06/14] vme: fake: Delete an error message for a failed memory  allocation in fake_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
  [PATCH 08/14] vme: fake: Adjust 11 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
  [PATCH 09/14] vme: ca91cx42: Delete eight error messages for a failed  memory allocation SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
  [PATCH 10/14] vme: ca91cx42: Improve 12 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
  [PATCH 13/14] vme: tsi148: Improve 17 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:20 +0200
    Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations Martyn Welch <martyn@welchs.me.uk> - 2017-08-25 23:00 +0200
      Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-26 09:10 +0200
        Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations Martyn Welch <martyn@welchs.me.uk> - 2017-08-30 21:50 +0200
          Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-30 23:00 +0200
  [PATCH 11/14] vme: ca91cx42: Adjust 14 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:20 +0200
  [PATCH 12/14] vme: tsi148: Delete nine error messages for a failed  memory allocation SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:20 +0200
  [PATCH 14/14] vme: tsi148: Adjust 14 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:20 +0200
  Re: [PATCH 00/14] VME: Adjustments for several function  implementations Martyn Welch <martyn@welchs.me.uk> - 2017-08-26 00:00 +0200
    Re: [PATCH 00/14] VME: Adjustments for several function  implementations Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-26 09:10 +0200

csiph-web