Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1720222
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 05/14] vme: Return directly in two functions |
| Date | 2017-08-25 18:10 +0200 |
| Message-ID | <uiplf-6dJ-3@gated-at.bofh.it> (permalink) |
| References | <uip1T-5RV-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 24 Aug 2017 22:32:14 +0200
Return directly without using an intermediate local variable
in these functions.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/vme/vme.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
index a2e36e6a0d84..986799d64993 100644
--- a/drivers/vme/vme.c
+++ b/drivers/vme/vme.c
@@ -1996,28 +1996,26 @@ static int vme_bus_match(struct device *dev, struct device_driver *drv)
static int vme_bus_probe(struct device *dev)
{
- int retval = -ENODEV;
struct vme_driver *driver;
struct vme_dev *vdev = dev_to_vme_dev(dev);
driver = dev->platform_data;
if (driver->probe)
- retval = driver->probe(vdev);
+ return driver->probe(vdev);
- return retval;
+ return -ENODEV;
}
static int vme_bus_remove(struct device *dev)
{
- int retval = -ENODEV;
struct vme_driver *driver;
struct vme_dev *vdev = dev_to_vme_dev(dev);
driver = dev->platform_data;
if (driver->remove)
- retval = driver->remove(vdev);
+ return driver->remove(vdev);
- return retval;
+ return -ENODEV;
}
struct bus_type vme_bus_type = {
--
2.14.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/14] VME: Adjustments for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 17:50 +0200
[PATCH 01/14] vme: Delete 11 error messages for a failed memory allocation SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:00 +0200
[PATCH 02/14] vme: Improve 11 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:00 +0200
[PATCH 03/14] vme: Move an assignment in vme_new_dma_list() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:00 +0200
[PATCH 04/14] vme: Adjust 48 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:00 +0200
[PATCH 07/14] vme: fake: Improve five size determinations in fake_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
[PATCH 05/14] vme: Return directly in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
[PATCH 06/14] vme: fake: Delete an error message for a failed memory allocation in fake_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
[PATCH 08/14] vme: fake: Adjust 11 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
[PATCH 09/14] vme: ca91cx42: Delete eight error messages for a failed memory allocation SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
[PATCH 10/14] vme: ca91cx42: Improve 12 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
[PATCH 13/14] vme: tsi148: Improve 17 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:20 +0200
Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations Martyn Welch <martyn@welchs.me.uk> - 2017-08-25 23:00 +0200
Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-26 09:10 +0200
Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations Martyn Welch <martyn@welchs.me.uk> - 2017-08-30 21:50 +0200
Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-30 23:00 +0200
[PATCH 11/14] vme: ca91cx42: Adjust 14 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:20 +0200
[PATCH 12/14] vme: tsi148: Delete nine error messages for a failed memory allocation SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:20 +0200
[PATCH 14/14] vme: tsi148: Adjust 14 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:20 +0200
Re: [PATCH 00/14] VME: Adjustments for several function implementations Martyn Welch <martyn@welchs.me.uk> - 2017-08-26 00:00 +0200
Re: [PATCH 00/14] VME: Adjustments for several function implementations Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-26 09:10 +0200
csiph-web