Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1720225
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 08/14] vme: fake: Adjust 11 checks for null pointers |
| Date | 2017-08-25 18:10 +0200 |
| Message-ID | <uiplf-6dJ-9@gated-at.bofh.it> (permalink) |
| References | <uip1T-5RV-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 25 Aug 2017 10:01:16 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code places.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/vme/bridges/vme_fake.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/vme/bridges/vme_fake.c b/drivers/vme/bridges/vme_fake.c
index 39f84df44557..7d83691047f4 100644
--- a/drivers/vme/bridges/vme_fake.c
+++ b/drivers/vme/bridges/vme_fake.c
@@ -409,7 +409,7 @@ static void fake_lm_check(struct fake_driver *bridge, unsigned long long addr,
/* Each location monitor covers 8 bytes */
if (((lm_base + (8 * i)) <= addr) &&
((lm_base + (8 * i) + 8) > addr)) {
- if (bridge->lm_callback[i] != NULL)
+ if (bridge->lm_callback[i])
bridge->lm_callback[i](
bridge->lm_data[i]);
}
@@ -866,7 +866,7 @@ static int fake_lm_set(struct vme_lm_resource *lm, unsigned long long lm_base,
/* If we already have a callback attached, we can't move it! */
for (i = 0; i < lm->monitors; i++) {
- if (bridge->lm_callback[i] != NULL) {
+ if (bridge->lm_callback[i]) {
mutex_unlock(&lm->mtx);
pr_err("Location monitor callback attached, can't reset\n");
return -EBUSY;
@@ -940,7 +940,7 @@ static int fake_lm_attach(struct vme_lm_resource *lm, int monitor,
}
/* Check that a callback isn't already attached */
- if (bridge->lm_callback[monitor] != NULL) {
+ if (bridge->lm_callback[monitor]) {
mutex_unlock(&lm->mtx);
pr_err("Existing callback attached\n");
return -EBUSY;
@@ -978,7 +978,7 @@ static int fake_lm_detach(struct vme_lm_resource *lm, int monitor)
/* If all location monitors disabled, disable global Location Monitor */
tmp = 0;
for (i = 0; i < lm->monitors; i++) {
- if (bridge->lm_callback[i] != NULL)
+ if (bridge->lm_callback[i])
tmp = 1;
}
@@ -1003,7 +1003,7 @@ static void *fake_alloc_consistent(struct device *parent, size_t size,
{
void *alloc = kmalloc(size, GFP_KERNEL);
- if (alloc != NULL)
+ if (alloc)
*dma = fake_ptr_to_pci(alloc);
return alloc;
@@ -1039,7 +1039,7 @@ static int fake_crcsr_init(struct vme_bridge *fake_bridge)
/* Allocate mem for CR/CSR image */
bridge->crcsr_kernel = kzalloc(VME_CRCSR_BUF_SIZE, GFP_KERNEL);
bridge->crcsr_bus = fake_ptr_to_pci(bridge->crcsr_kernel);
- if (bridge->crcsr_kernel == NULL)
+ if (!bridge->crcsr_kernel)
return -ENOMEM;
vstat = fake_slot_get(fake_bridge);
@@ -1076,13 +1076,13 @@ static int __init fake_init(void)
* dynamically allocate this so we get one per device.
*/
fake_bridge = kzalloc(sizeof(*fake_bridge), GFP_KERNEL);
- if (fake_bridge == NULL) {
+ if (!fake_bridge) {
retval = -ENOMEM;
goto err_struct;
}
fake_device = kzalloc(sizeof(*fake_device), GFP_KERNEL);
- if (fake_device == NULL) {
+ if (!fake_device) {
retval = -ENOMEM;
goto err_driver;
}
@@ -1105,7 +1105,7 @@ static int __init fake_init(void)
INIT_LIST_HEAD(&fake_bridge->master_resources);
for (i = 0; i < FAKE_MAX_MASTER; i++) {
master_image = kmalloc(sizeof(*master_image), GFP_KERNEL);
- if (master_image == NULL) {
+ if (!master_image) {
retval = -ENOMEM;
goto err_master;
}
@@ -1131,7 +1131,7 @@ static int __init fake_init(void)
INIT_LIST_HEAD(&fake_bridge->slave_resources);
for (i = 0; i < FAKE_MAX_SLAVE; i++) {
slave_image = kmalloc(sizeof(*slave_image), GFP_KERNEL);
- if (slave_image == NULL) {
+ if (!slave_image) {
retval = -ENOMEM;
goto err_slave;
}
@@ -1153,7 +1153,7 @@ static int __init fake_init(void)
/* Add location monitor to list */
INIT_LIST_HEAD(&fake_bridge->lm_resources);
lm = kmalloc(sizeof(*lm), GFP_KERNEL);
- if (lm == NULL) {
+ if (!lm) {
retval = -ENOMEM;
goto err_lm;
}
--
2.14.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/14] VME: Adjustments for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 17:50 +0200
[PATCH 01/14] vme: Delete 11 error messages for a failed memory allocation SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:00 +0200
[PATCH 02/14] vme: Improve 11 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:00 +0200
[PATCH 03/14] vme: Move an assignment in vme_new_dma_list() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:00 +0200
[PATCH 04/14] vme: Adjust 48 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:00 +0200
[PATCH 07/14] vme: fake: Improve five size determinations in fake_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
[PATCH 05/14] vme: Return directly in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
[PATCH 06/14] vme: fake: Delete an error message for a failed memory allocation in fake_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
[PATCH 08/14] vme: fake: Adjust 11 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
[PATCH 09/14] vme: ca91cx42: Delete eight error messages for a failed memory allocation SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
[PATCH 10/14] vme: ca91cx42: Improve 12 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:10 +0200
[PATCH 13/14] vme: tsi148: Improve 17 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:20 +0200
Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations Martyn Welch <martyn@welchs.me.uk> - 2017-08-25 23:00 +0200
Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-26 09:10 +0200
Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations Martyn Welch <martyn@welchs.me.uk> - 2017-08-30 21:50 +0200
Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-30 23:00 +0200
[PATCH 11/14] vme: ca91cx42: Adjust 14 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:20 +0200
[PATCH 12/14] vme: tsi148: Delete nine error messages for a failed memory allocation SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:20 +0200
[PATCH 14/14] vme: tsi148: Adjust 14 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 18:20 +0200
Re: [PATCH 00/14] VME: Adjustments for several function implementations Martyn Welch <martyn@welchs.me.uk> - 2017-08-26 00:00 +0200
Re: [PATCH 00/14] VME: Adjustments for several function implementations Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-26 09:10 +0200
csiph-web