Re: [PATCH net-next 7/8] net: hns3: add vlan filter config of Ports

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 7/8] net: hns3: add vlan filter config of Ports
Date	2017-08-31 23:40 +0200
Message-ID	<ukFlT-2Gx-9@gated-at.bofh.it> (permalink)
References	<ukxy1-65y-7@gated-at.bofh.it> <ukxy1-65y-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Lipeng <lipeng321@huawei.com>
Date: Thu, 31 Aug 2017 21:39:08 +0800

> Config the self_define vlan_type as TPID(0x8100) for vlan identification.
> When normal port initialize vlan configure, set default vlan id as 0.
> 
> Signed-off-by: Mingguang Qu <qumingguang@huawei.com>
> Signed-off-by: Lipeng <lipeng321@huawei.com>

No, that's not what this patch is doing.

> @@ -3308,6 +3308,7 @@ static int hclge_add_mac_vlan_tbl(struct hclge_vport *vport,
>  		mc_desc[1].flag |= cpu_to_le16(HCLGE_CMD_FLAG_NEXT);
>  		hclge_cmd_reuse_desc(&mc_desc[2], false);
>  		mc_desc[2].flag &= cpu_to_le16(~HCLGE_CMD_FLAG_NEXT);
> +
>  		memcpy(mc_desc[0].data, req,
>  		       sizeof(struct hclge_mac_vlan_tbl_entry));
>  		ret = hclge_cmd_send(&hdev->hw, mc_desc, 3);

All it does is add an empty line.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 7/8] net: hns3: add vlan filter config of Ports Lipeng <lipeng321@huawei.com> - 2017-08-31 15:20 +0200
  Re: [PATCH net-next 7/8] net: hns3: add vlan filter config of Ports David Miller <davem@davemloft.net> - 2017-08-31 23:40 +0200

csiph-web