Re: [PATCH net-next] net/ncsi: Define {add, kill}_vid callbacks for !CONFIG_NET_NCSI

From	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next] net/ncsi: Define {add, kill}_vid callbacks for !CONFIG_NET_NCSI
Date	2017-08-31 23:40 +0200
Message-ID	<ukFlT-2Gx-13@gated-at.bofh.it> (permalink)
References	<ukouK-mT-3@gated-at.bofh.it> <ukzzP-7k7-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2017-08-31 at 08:24 -0700, Vernon Mauery wrote:
>  +int ncsi_vlan_rx_add_vid(struct net_device *dev, __be16 proto, u16 vid)
> > +{
> > +     return -ENOTTY;
> > +}
> > +int ncsi_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16 vid)
> > +{
> > +     return -ENOTTY;
> > +}
> 
> These should be static functions because they are defined in the header 
> file or you will get multiple symbol definitions.

static inline even or you'll get warning about them being unused iirc.

Cheers,
Ben.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net/ncsi: Define {add,kill}_vid callbacks for !CONFIG_NET_NCSI Samuel Mendoza-Jonas <sam@mendozajonas.com> - 2017-08-31 05:40 +0200
  Re: [PATCH net-next] net/ncsi: Define {add,kill}_vid callbacks for !CONFIG_NET_NCSI Florian Fainelli <f.fainelli@gmail.com> - 2017-08-31 06:10 +0200
  Re: [PATCH net-next] net/ncsi: Define {add, kill}_vid callbacks for  !CONFIG_NET_NCSI Vernon Mauery <vernon.mauery@linux.intel.com> - 2017-08-31 17:30 +0200
    Re: [PATCH net-next] net/ncsi: Define {add, kill}_vid callbacks for  !CONFIG_NET_NCSI Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2017-08-31 23:40 +0200

csiph-web