Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1724211 > unrolled thread

[PATCH net-next 7/8] net: hns3: add vlan filter config of Ports

Started byLipeng <lipeng321@huawei.com>
First post2017-08-31 15:20 +0200
Last post2017-08-31 23:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH net-next 7/8] net: hns3: add vlan filter config of Ports Lipeng <lipeng321@huawei.com> - 2017-08-31 15:20 +0200
    Re: [PATCH net-next 7/8] net: hns3: add vlan filter config of Ports David Miller <davem@davemloft.net> - 2017-08-31 23:40 +0200

#1724211 — [PATCH net-next 7/8] net: hns3: add vlan filter config of Ports

FromLipeng <lipeng321@huawei.com>
Date2017-08-31 15:20 +0200
Subject[PATCH net-next 7/8] net: hns3: add vlan filter config of Ports
Message-ID<ukxy1-65y-5@gated-at.bofh.it>
Config the self_define vlan_type as TPID(0x8100) for vlan identification.
When normal port initialize vlan configure, set default vlan id as 0.

Signed-off-by: Mingguang Qu <qumingguang@huawei.com>
Signed-off-by: Lipeng <lipeng321@huawei.com>
---
 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
index 12be24f..d0a30f5 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
@@ -3308,6 +3308,7 @@ static int hclge_add_mac_vlan_tbl(struct hclge_vport *vport,
 		mc_desc[1].flag |= cpu_to_le16(HCLGE_CMD_FLAG_NEXT);
 		hclge_cmd_reuse_desc(&mc_desc[2], false);
 		mc_desc[2].flag &= cpu_to_le16(~HCLGE_CMD_FLAG_NEXT);
+
 		memcpy(mc_desc[0].data, req,
 		       sizeof(struct hclge_mac_vlan_tbl_entry));
 		ret = hclge_cmd_send(&hdev->hw, mc_desc, 3);
-- 
1.9.1

[toc] | [next] | [standalone]


#1724611

FromDavid Miller <davem@davemloft.net>
Date2017-08-31 23:40 +0200
Message-ID<ukFlT-2Gx-9@gated-at.bofh.it>
In reply to#1724211
From: Lipeng <lipeng321@huawei.com>
Date: Thu, 31 Aug 2017 21:39:08 +0800

> Config the self_define vlan_type as TPID(0x8100) for vlan identification.
> When normal port initialize vlan configure, set default vlan id as 0.
> 
> Signed-off-by: Mingguang Qu <qumingguang@huawei.com>
> Signed-off-by: Lipeng <lipeng321@huawei.com>

No, that's not what this patch is doing.

> @@ -3308,6 +3308,7 @@ static int hclge_add_mac_vlan_tbl(struct hclge_vport *vport,
>  		mc_desc[1].flag |= cpu_to_le16(HCLGE_CMD_FLAG_NEXT);
>  		hclge_cmd_reuse_desc(&mc_desc[2], false);
>  		mc_desc[2].flag &= cpu_to_le16(~HCLGE_CMD_FLAG_NEXT);
> +
>  		memcpy(mc_desc[0].data, req,
>  		       sizeof(struct hclge_mac_vlan_tbl_entry));
>  		ret = hclge_cmd_send(&hdev->hw, mc_desc, 3);

All it does is add an empty line.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web