Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1719570

Re: [PATCH v2] x86/microcode: Silence a static checker warning

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] x86/microcode: Silence a static checker warning
Date 2017-08-24 23:10 +0200
Message-ID <ui7y1-3iu-13@gated-at.bofh.it> (permalink)
References <ui6LF-2Jv-31@gated-at.bofh.it> <ui6LF-2Jv-29@gated-at.bofh.it> <ui7eG-2Ut-21@gated-at.bofh.it> <ui7ol-2YO-7@gated-at.bofh.it> <ui7ol-2YO-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 24, 2017 at 10:58:44PM +0200, Borislav Petkov wrote:
> On Thu, Aug 24, 2017 at 11:55:10PM +0300, Dan Carpenter wrote:
> > This is just cleanups and doesn't change the behavior.
> 
> You can't return from in the middle of the loop just because the
> allocation fails.
> 

I understand that.

> > The static checker is still going to complain about the error pointer
> > from the loop.
> 
> Please drop this argument about the static checker which you write. I'm
> certainly not changing code just because some tool complains.

Sure.  But the point is the same...  The "p" is an error pointer at the
end of the function.

> 
> > Perhaps we should only set prev_found if the memdup_patch()
> > inside the loop succeeds?
> 
> This not why we set prev_found.

Sure.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] x86/microcode: Silence a static checker warning Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-24 22:20 +0200
  Re: [PATCH v2] x86/microcode: Silence a static checker warning Borislav Petkov <bp@alien8.de> - 2017-08-24 22:50 +0200
    Re: [PATCH v2] x86/microcode: Silence a static checker warning Borislav Petkov <bp@alien8.de> - 2017-08-24 23:00 +0200
      Re: [PATCH v2] x86/microcode: Silence a static checker warning Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-24 23:10 +0200
        Re: [PATCH v2] x86/microcode: Silence a static checker warning Borislav Petkov <bp@alien8.de> - 2017-08-24 23:20 +0200
          Re: [PATCH v2] x86/microcode: Silence a static checker warning Borislav Petkov <bp@alien8.de> - 2017-08-25 11:10 +0200
            Re: [PATCH v2] x86/microcode: Silence a static checker warning Borislav Petkov <bp@alien8.de> - 2017-08-25 11:20 +0200
              [PATCH] x86/microcode/intel: Improve microcode patches saving flow Borislav Petkov <bp@alien8.de> - 2017-08-25 12:10 +0200
                Re: [PATCH] x86/microcode/intel: Improve microcode patches saving  flow walter harms <wharms@bfs.de> - 2017-08-25 12:50 +0200
                Re: [PATCH] x86/microcode/intel: Improve microcode patches saving  flow Borislav Petkov <bp@alien8.de> - 2017-08-25 13:50 +0200
                [tip:x86/microcode] x86/microcode/intel: Improve microcode patches  saving flow tip-bot for Borislav Petkov <tipbot@zytor.com> - 2017-08-29 11:10 +0200
            Re: [PATCH v2] x86/microcode: Silence a static checker warning Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-25 11:20 +0200
    Re: [PATCH v2] x86/microcode: Silence a static checker warning Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-24 23:00 +0200
    Re: [PATCH v2] x86/microcode: Silence a static checker warning Joe Perches <joe@perches.com> - 2017-08-24 23:10 +0200

csiph-web