Groups > linux.kernel > #1719339

Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test
Date	Thu, 24 Aug 2017 17:30:02 +0200
Message-ID	<ui2f0-8jI-21@gated-at.bofh.it> (permalink)
References	<uhorg-7Cb-23@gated-at.bofh.it> <uhQnv-tt-1@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding	7bit
X-Antiabuse	This header was added to track abuse, please include it with any abuse report
X-Antiabuse	Primary Hostname - gator4166.hostgator.com
X-Antiabuse	Original Domain - vger.kernel.org
X-Antiabuse	Originator/Caller UID/GID - [47 12] / [47 12]
X-Antiabuse	Sender Address Domain - embeddedor.com
X-Bwhitelist	no
X-Source-IP	189.152.158.27
X-Exim-ID	1dku1a-002Den-4f
X-Source-Sender	([192.168.1.70]) [189.152.158.27]:56246
X-Source-Auth	gustavo@embeddedor.com
X-Email-Count	6
X-Source-Cap	Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20=
X-Local-Domain	yes
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	17
Organization	linux.* mail to news gateway
X-Original-Cc	James Smart <james.smart@broadcom.com>, Dick Kennedy <dick.kennedy@broadcom.com>, "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 24 Aug 2017 10:26:19 -0500
X-Original-Message-ID	<7edf46e6-1b3a-52dd-2c15-d72c3f7a9eb9@embeddedor.com>
X-Original-References	<20170822205353.GA17794@embeddedgus> <yq1d17ladk5.fsf@oracle.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1719339

Show key headers only | View raw

Hi Martin,

On 08/23/2017 09:45 PM, Martin K. Petersen wrote:
>
> Gustavo,
>
>> Remove variable assignments. The value stored in local variable _rc_
>> is overwritten at line 2448:rc =
>> lpfc_sli4_bsg_set_link_diag_state(phba, 0); before it can be used.
>
> Applied to 4.14/scsi-queue. Thank you!
>

Glad to help. :)

-- 
Gustavo A. R. Silva

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: lpfc: remove useless code in  lpfc_sli4_bsg_link_diag_test "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-22 23:00 +0200
  Re: [PATCH] scsi: lpfc: remove useless code in  lpfc_sli4_bsg_link_diag_test James Smart <james.smart@broadcom.com> - 2017-08-23 18:30 +0200
  Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-08-24 04:50 +0200
    Re: [PATCH] scsi: lpfc: remove useless code in  lpfc_sli4_bsg_link_diag_test "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-24 17:30 +0200

csiph-web