Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1718497
| From | James Smart <james.smart@broadcom.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test |
| Date | 2017-08-23 18:30 +0200 |
| Message-ID | <uhGHv-2Qt-3@gated-at.bofh.it> (permalink) |
| References | <uhorg-7Cb-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 8/22/2017 1:53 PM, Gustavo A. R. Silva wrote: > Remove variable assignments. The value stored in local variable _rc_ is > overwritten at line 2448:rc = lpfc_sli4_bsg_set_link_diag_state(phba, 0); > before it can be used. > > Addresses-Coverity-ID: 1226935 > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > This issue was detected by Coverity and it was tested by compilation only. > Notice that this code has been there since 2011. > > drivers/scsi/lpfc/lpfc_bsg.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > looks good. Thanks Signed-off-by: James Smart <james.smart@broadcom.com> -- james
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-22 23:00 +0200
Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test James Smart <james.smart@broadcom.com> - 2017-08-23 18:30 +0200
Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-08-24 04:50 +0200
Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-24 17:30 +0200
csiph-web