Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1718787

Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test

From "Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test
Date 2017-08-24 04:50 +0200
Message-ID <uhQnv-tt-1@gated-at.bofh.it> (permalink)
References <uhorg-7Cb-23@gated-at.bofh.it>
Organization Oracle Corporation

Show all headers | View raw


Gustavo,

> Remove variable assignments. The value stored in local variable _rc_
> is overwritten at line 2448:rc =
> lpfc_sli4_bsg_set_link_diag_state(phba, 0); before it can be used.

Applied to 4.14/scsi-queue. Thank you!

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] scsi: lpfc: remove useless code in  lpfc_sli4_bsg_link_diag_test "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-22 23:00 +0200
  Re: [PATCH] scsi: lpfc: remove useless code in  lpfc_sli4_bsg_link_diag_test James Smart <james.smart@broadcom.com> - 2017-08-23 18:30 +0200
  Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-08-24 04:50 +0200
    Re: [PATCH] scsi: lpfc: remove useless code in  lpfc_sli4_bsg_link_diag_test "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-24 17:30 +0200

csiph-web