Groups > linux.kernel > #1719184

Re: [PATCH] ARM: OMAP2+: fix missing variable declaration

From	Tomi Valkeinen <tomi.valkeinen@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: OMAP2+: fix missing variable declaration
Date	2017-08-24 14:20 +0200
Message-ID	<uhZh7-6r5-3@gated-at.bofh.it> (permalink)
References	<uhDTk-14P-9@gated-at.bofh.it> <uhEmm-1ex-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw



Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

On 23/08/17 16:53, Laurent Pinchart wrote:
> Hi Arnd,
> 
> On Wednesday, 23 August 2017 16:28:19 EEST Arnd Bergmann wrote:
>> The function that was added doesn't actually build:
>>
>> arch/arm/mach-omap2/display.c: In function 'omapdss_init_fbdev':
>> arch/arm/mach-omap2/display.c:184:2: error: 'r' undeclared (first use in
>> this function)
>>
>> This adds a declaration for 'r' to fix it.
>>
>> Fixes: 5ce783025c82 ("ARM: OMAP2+: Don't register omapdss device for
>> omapdrm")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Looks like I haven't tested the patch with CONFIG_FB_OMAP2 enabled after the 
> last rebase. I'm very sorry about that :-(
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Tomi, I assume you will pick this up and sent it to Dave for v4.14-rc1.

Yep, I'll pick it up. I could swear I tested omapfb build, but...
Obviously not.

 Tomi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: OMAP2+: fix missing variable declaration Arnd Bergmann <arnd@arndb.de> - 2017-08-23 15:30 +0200
  Re: [PATCH] ARM: OMAP2+: fix missing variable declaration Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-08-23 16:00 +0200
    Re: [PATCH] ARM: OMAP2+: fix missing variable declaration Tony Lindgren <tony@atomide.com> - 2017-08-23 17:00 +0200
    Re: [PATCH] ARM: OMAP2+: fix missing variable declaration Tomi Valkeinen <tomi.valkeinen@ti.com> - 2017-08-24 14:20 +0200

csiph-web