Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1718436

Re: [PATCH] ARM: OMAP2+: fix missing variable declaration

From Tony Lindgren <tony@atomide.com>
Newsgroups linux.kernel
Subject Re: [PATCH] ARM: OMAP2+: fix missing variable declaration
Date 2017-08-23 17:00 +0200
Message-ID <uhFip-1PN-13@gated-at.bofh.it> (permalink)
References <uhDTk-14P-9@gated-at.bofh.it> <uhEmm-1ex-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [170823 06:53]:
> Hi Arnd,
> 
> On Wednesday, 23 August 2017 16:28:19 EEST Arnd Bergmann wrote:
> > The function that was added doesn't actually build:
> > 
> > arch/arm/mach-omap2/display.c: In function 'omapdss_init_fbdev':
> > arch/arm/mach-omap2/display.c:184:2: error: 'r' undeclared (first use in
> > this function)
> > 
> > This adds a declaration for 'r' to fix it.
> > 
> > Fixes: 5ce783025c82 ("ARM: OMAP2+: Don't register omapdss device for
> > omapdrm")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Looks like I haven't tested the patch with CONFIG_FB_OMAP2 enabled after the 
> last rebase. I'm very sorry about that :-(
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Tomi, I assume you will pick this up and sent it to Dave for v4.14-rc1.

Acked-by: Tony Lindgren <tony@atomide.com>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ARM: OMAP2+: fix missing variable declaration Arnd Bergmann <arnd@arndb.de> - 2017-08-23 15:30 +0200
  Re: [PATCH] ARM: OMAP2+: fix missing variable declaration Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-08-23 16:00 +0200
    Re: [PATCH] ARM: OMAP2+: fix missing variable declaration Tony Lindgren <tony@atomide.com> - 2017-08-23 17:00 +0200
    Re: [PATCH] ARM: OMAP2+: fix missing variable declaration Tomi Valkeinen <tomi.valkeinen@ti.com> - 2017-08-24 14:20 +0200

csiph-web