Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1718376

Re: [PATCH] ARM: OMAP2+: fix missing variable declaration

Show all headers | View raw

Hi Arnd,

On Wednesday, 23 August 2017 16:28:19 EEST Arnd Bergmann wrote:
> The function that was added doesn't actually build:
> 
> arch/arm/mach-omap2/display.c: In function 'omapdss_init_fbdev':
> arch/arm/mach-omap2/display.c:184:2: error: 'r' undeclared (first use in
> this function)
> 
> This adds a declaration for 'r' to fix it.
> 
> Fixes: 5ce783025c82 ("ARM: OMAP2+: Don't register omapdss device for
> omapdrm")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Looks like I haven't tested the patch with CONFIG_FB_OMAP2 enabled after the 
last rebase. I'm very sorry about that :-(

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Tomi, I assume you will pick this up and sent it to Dave for v4.14-rc1.

> ---
>  arch/arm/mach-omap2/display.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c
> index 798fc718fffe..b3f6eb5d04a2 100644
> --- a/arch/arm/mach-omap2/display.c
> +++ b/arch/arm/mach-omap2/display.c
> @@ -172,6 +172,7 @@ static int __init omapdss_init_fbdev(void)
>  		.set_min_bus_tput = omap_dss_set_min_bus_tput,
>  	};
>  	struct device_node *node;
> +	int r;
> 
>  	board_data.version = omap_display_get_version();
>  	if (board_data.version == OMAPDSS_VER_UNKNOWN) {


-- 
Regards,

Laurent Pinchart

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: OMAP2+: fix missing variable declaration Arnd Bergmann <arnd@arndb.de> - 2017-08-23 15:30 +0200
  Re: [PATCH] ARM: OMAP2+: fix missing variable declaration Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-08-23 16:00 +0200
    Re: [PATCH] ARM: OMAP2+: fix missing variable declaration Tony Lindgren <tony@atomide.com> - 2017-08-23 17:00 +0200
    Re: [PATCH] ARM: OMAP2+: fix missing variable declaration Tomi Valkeinen <tomi.valkeinen@ti.com> - 2017-08-24 14:20 +0200

csiph-web