Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1718920

Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all part of PROVE_LOCKING

From Byungchul Park <byungchul.park@lge.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all part of PROVE_LOCKING
Date 2017-08-24 09:40 +0200
Message-ID <uhUU9-3rL-1@gated-at.bofh.it> (permalink)
References (5 earlier) <uhhSP-39j-21@gated-at.bofh.it> <uhiFb-3Hr-17@gated-at.bofh.it> <uhGRe-2TW-49@gated-at.bofh.it> <uhHWW-3yG-13@gated-at.bofh.it> <uhTEJ-2Mj-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 24, 2017 at 03:11:53PM +0900, Byungchul Park wrote:
> On Wed, Aug 23, 2017 at 07:47:14PM +0200, Peter Zijlstra wrote:
> > Those are fine and are indeed the flush_work() vs work inversion.
> > 
> > The two straight forward annotations are:
> > 
> > flush_work(work)	process_one_work(wq, work)
> >   A(work)		  A(work)
> >   R(work)		  work->func(work);
> > 			  R(work)
> > 
> > Which catches:
> > 
> > Task-1:			work:
> > 
> >   mutex_lock(&A);	mutex_lock(&A);
> >   flush_work(work);
> 
> I'm not sure but, with LOCKDEP_COMPLETE enabled, this issue would
> automatically be covered w/o additional A(work)/R(work). Right?
> 
> A(work)/R(work) seem to be used for preventing wait_for_completion()
> in flush_work() from waiting for the completion forever because of the
> work using mutex_lock(&A). Am I understanding correctly?
> 
> If yes, we can use just LOCKDEP_COMPLETE for that purpose.

I'm not familiar with workqueue but, the manual lockdep_map_acquire() in
workqueue code seems to be introduced to do what LOCKDEP_COMPLETE does
for wait_for_completion() and complete().

Wrong?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-17 11:00 +0200
  [PATCH v3 2/3] lockdep: Reword title of LOCKDEP_CROSSRELEASE config Byungchul Park <byungchul.park@lge.com> - 2017-08-17 11:00 +0200
    [tip:locking/core] locking/lockdep: Reword title of  LOCKDEP_CROSSRELEASE config tip-bot for Byungchul Park <tipbot@zytor.com> - 2017-08-17 12:30 +0200
  [PATCH v3 3/3] lockdep: Rename LOCKDEP_COMPLETE config Byungchul Park <byungchul.park@lge.com> - 2017-08-17 11:00 +0200
    [tip:locking/core] locking/lockdep: Rename CONFIG_LOCKDEP_COMPLETE  to CONFIG_LOCKDEP_COMPLETIONS tip-bot for Byungchul Park <tipbot@zytor.com> - 2017-08-17 12:30 +0200
  [tip:locking/core] locking/lockdep: Make  CONFIG_LOCKDEP_CROSSRELEASE part of CONFIG_PROVE_LOCKING tip-bot for Byungchul Park <tipbot@zytor.com> - 2017-08-17 12:30 +0200
    Re: [tip:locking/core] locking/lockdep: Make  CONFIG_LOCKDEP_CROSSRELEASE part of CONFIG_PROVE_LOCKING Ingo Molnar <mingo@kernel.org> - 2017-08-17 12:50 +0200
      Re: [tip:locking/core] locking/lockdep: Make  CONFIG_LOCKDEP_CROSSRELEASE part of CONFIG_PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-18 07:40 +0200
  Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-21 17:50 +0200
    Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-22 07:20 +0200
      Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 10:00 +0200
        Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-22 11:00 +0200
          Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 11:30 +0200
            Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-22 11:40 +0200
              Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 12:10 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 16:00 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 16:50 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 17:20 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Oleg Nesterov <oleg@redhat.com> - 2017-08-22 18:00 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 18:40 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Oleg Nesterov <oleg@redhat.com> - 2017-08-23 18:40 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-23 19:50 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 08:20 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 09:40 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 10:20 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-25 03:20 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 04:50 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 08:40 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-23 12:30 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 07:10 +0200
    Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Dave Chinner <david@fromorbit.com> - 2017-08-22 07:50 +0200
      Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 11:10 +0200
        Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-22 11:30 +0200
          Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 11:40 +0200
            Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 11:50 +0200
            Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 04:20 +0200
              Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 08:10 +0200
              Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-23 12:30 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 04:10 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 09:40 +0200
        Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Dave Chinner <david@fromorbit.com> - 2017-08-22 23:20 +0200
        Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 04:40 +0200
          Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 08:20 +0200
          Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-23 12:50 +0200
            Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 07:10 +0200
      Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 04:00 +0200

csiph-web