Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1713811

Re: [tip:locking/core] locking/lockdep: Make CONFIG_LOCKDEP_CROSSRELEASE part of CONFIG_PROVE_LOCKING

From Ingo Molnar <mingo@kernel.org>
Newsgroups linux.kernel
Subject Re: [tip:locking/core] locking/lockdep: Make CONFIG_LOCKDEP_CROSSRELEASE part of CONFIG_PROVE_LOCKING
Date 2017-08-17 12:50 +0200
Message-ID <ufqxd-3DI-13@gated-at.bofh.it> (permalink)
References <ufoOJ-2qX-1@gated-at.bofh.it> <ufqdP-3w2-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

* tip-bot for Byungchul Park <tipbot@zytor.com> wrote:

> Commit-ID:  d0541b0fa64b36665d6261079974a26943c75009
> Gitweb:     http://git.kernel.org/tip/d0541b0fa64b36665d6261079974a26943c75009
> Author:     Byungchul Park <byungchul.park@lge.com>
> AuthorDate: Thu, 17 Aug 2017 17:57:39 +0900
> Committer:  Ingo Molnar <mingo@kernel.org>
> CommitDate: Thu, 17 Aug 2017 11:38:54 +0200
> 
> locking/lockdep: Make CONFIG_LOCKDEP_CROSSRELEASE part of CONFIG_PROVE_LOCKING
> 
> Crossrelease support added the CONFIG_LOCKDEP_CROSSRELEASE and CONFIG_LOCKDEP_COMPLETE
> options. It makes little sense to enable them when PROVE_LOCKING is disabled.
> 
> Make them non-interative options and part of PROVE_LOCKING to simplify the UI.
> 
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: kernel-team@lge.com
> Link: http://lkml.kernel.org/r/1502960261-16206-1-git-send-email-byungchul.park@lge.com
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> ---
>  lib/Kconfig.debug | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index ebd40d3..1ad7f1b 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1081,6 +1081,8 @@ config PROVE_LOCKING
>  	select DEBUG_MUTEXES
>  	select DEBUG_RT_MUTEXES if RT_MUTEXES
>  	select DEBUG_LOCK_ALLOC
> +	select LOCKDEP_CROSSRELEASE
> +	select LOCKDEP_COMPLETE
>  	select TRACE_IRQFLAGS
>  	default n
>  	help
> @@ -1152,8 +1154,6 @@ config LOCK_STAT
>  
>  config LOCKDEP_CROSSRELEASE
>  	bool "Lock debugging: make lockdep work for crosslocks"
> -	depends on PROVE_LOCKING
> -	default n
>  	help
>  	 This makes lockdep work for crosslock which is a lock allowed to
>  	 be released in a different context from the acquisition context.
> @@ -1164,9 +1164,6 @@ config LOCKDEP_CROSSRELEASE
>  
>  config LOCKDEP_COMPLETE
>  	bool "Lock debugging: allow completions to use deadlock detector"
> -	depends on PROVE_LOCKING
> -	select LOCKDEP_CROSSRELEASE
> -	default n
>  	help

Yeah, so I only noticed this after committing the patches, but this change does 
not make the option non-interactive. The way to do that is to remove the "" help 
text, i.e. make it a simple 'bool'.

I'll do that and re-push.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-17 11:00 +0200
  [PATCH v3 2/3] lockdep: Reword title of LOCKDEP_CROSSRELEASE config Byungchul Park <byungchul.park@lge.com> - 2017-08-17 11:00 +0200
    [tip:locking/core] locking/lockdep: Reword title of  LOCKDEP_CROSSRELEASE config tip-bot for Byungchul Park <tipbot@zytor.com> - 2017-08-17 12:30 +0200
  [PATCH v3 3/3] lockdep: Rename LOCKDEP_COMPLETE config Byungchul Park <byungchul.park@lge.com> - 2017-08-17 11:00 +0200
    [tip:locking/core] locking/lockdep: Rename CONFIG_LOCKDEP_COMPLETE  to CONFIG_LOCKDEP_COMPLETIONS tip-bot for Byungchul Park <tipbot@zytor.com> - 2017-08-17 12:30 +0200
  [tip:locking/core] locking/lockdep: Make  CONFIG_LOCKDEP_CROSSRELEASE part of CONFIG_PROVE_LOCKING tip-bot for Byungchul Park <tipbot@zytor.com> - 2017-08-17 12:30 +0200
    Re: [tip:locking/core] locking/lockdep: Make  CONFIG_LOCKDEP_CROSSRELEASE part of CONFIG_PROVE_LOCKING Ingo Molnar <mingo@kernel.org> - 2017-08-17 12:50 +0200
      Re: [tip:locking/core] locking/lockdep: Make  CONFIG_LOCKDEP_CROSSRELEASE part of CONFIG_PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-18 07:40 +0200
  Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-21 17:50 +0200
    Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-22 07:20 +0200
      Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 10:00 +0200
        Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-22 11:00 +0200
          Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 11:30 +0200
            Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-22 11:40 +0200
              Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 12:10 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 16:00 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 16:50 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 17:20 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Oleg Nesterov <oleg@redhat.com> - 2017-08-22 18:00 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 18:40 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Oleg Nesterov <oleg@redhat.com> - 2017-08-23 18:40 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-23 19:50 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 08:20 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 09:40 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 10:20 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-25 03:20 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 04:50 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 08:40 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-23 12:30 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 07:10 +0200
    Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Dave Chinner <david@fromorbit.com> - 2017-08-22 07:50 +0200
      Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 11:10 +0200
        Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-22 11:30 +0200
          Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 11:40 +0200
            Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 11:50 +0200
            Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 04:20 +0200
              Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 08:10 +0200
              Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-23 12:30 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 04:10 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 09:40 +0200
        Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Dave Chinner <david@fromorbit.com> - 2017-08-22 23:20 +0200
        Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 04:40 +0200
          Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 08:20 +0200
          Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-23 12:50 +0200
            Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 07:10 +0200
      Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 04:00 +0200

csiph-web