Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1718516

Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all part of PROVE_LOCKING

From Oleg Nesterov <oleg@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all part of PROVE_LOCKING
Date 2017-08-23 18:40 +0200
Message-ID <uhGRe-2TW-49@gated-at.bofh.it> (permalink)
References (5 earlier) <uhdFw-ng-21@gated-at.bofh.it> <uhdPb-qO-1@gated-at.bofh.it> <uheie-T0-27@gated-at.bofh.it> <uhhSP-39j-21@gated-at.bofh.it> <uhiFb-3Hr-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Peter, I am all confused and I am still trying to understand your email.
In particular, because I no longer understand the lockdep annotations in
workqueue.c, it turns out I forgot everything...

On 08/22, Peter Zijlstra wrote:
>
> I am however slightly puzzled by the need of flush_work() to take Q,
> what deadlock potential is there?

Do you really mean flush_work()? Or start_flush_work() ?

> It was added by Oleg in commit:
>
>   a67da70dc095 ("workqueues: lockdep annotations for flush_work()")

No, these annotations were moved later into start_flush, iiuc...

This

	lock_map_acquire(&work->lockdep_map);
	lock_map_release(&work->lockdep_map);

was added by another commit 0976dfc1d0cd80a4e9dfaf87bd8744612bde475a
"workqueue: Catch more locking problems with flush_work()", and at
first glance it is fine.

At the same time, I have a vague feeling that (perhaps) we can remove
these 2 annotations if we change process_one_work() and start_flush_work(),
not sure...

Oleg.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-17 11:00 +0200
  [PATCH v3 2/3] lockdep: Reword title of LOCKDEP_CROSSRELEASE config Byungchul Park <byungchul.park@lge.com> - 2017-08-17 11:00 +0200
    [tip:locking/core] locking/lockdep: Reword title of  LOCKDEP_CROSSRELEASE config tip-bot for Byungchul Park <tipbot@zytor.com> - 2017-08-17 12:30 +0200
  [PATCH v3 3/3] lockdep: Rename LOCKDEP_COMPLETE config Byungchul Park <byungchul.park@lge.com> - 2017-08-17 11:00 +0200
    [tip:locking/core] locking/lockdep: Rename CONFIG_LOCKDEP_COMPLETE  to CONFIG_LOCKDEP_COMPLETIONS tip-bot for Byungchul Park <tipbot@zytor.com> - 2017-08-17 12:30 +0200
  [tip:locking/core] locking/lockdep: Make  CONFIG_LOCKDEP_CROSSRELEASE part of CONFIG_PROVE_LOCKING tip-bot for Byungchul Park <tipbot@zytor.com> - 2017-08-17 12:30 +0200
    Re: [tip:locking/core] locking/lockdep: Make  CONFIG_LOCKDEP_CROSSRELEASE part of CONFIG_PROVE_LOCKING Ingo Molnar <mingo@kernel.org> - 2017-08-17 12:50 +0200
      Re: [tip:locking/core] locking/lockdep: Make  CONFIG_LOCKDEP_CROSSRELEASE part of CONFIG_PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-18 07:40 +0200
  Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-21 17:50 +0200
    Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-22 07:20 +0200
      Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 10:00 +0200
        Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-22 11:00 +0200
          Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 11:30 +0200
            Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-22 11:40 +0200
              Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 12:10 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 16:00 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 16:50 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 17:20 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Oleg Nesterov <oleg@redhat.com> - 2017-08-22 18:00 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 18:40 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Oleg Nesterov <oleg@redhat.com> - 2017-08-23 18:40 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-23 19:50 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 08:20 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 09:40 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 10:20 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-25 03:20 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 04:50 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 08:40 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-23 12:30 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 07:10 +0200
    Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Dave Chinner <david@fromorbit.com> - 2017-08-22 07:50 +0200
      Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 11:10 +0200
        Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-22 11:30 +0200
          Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 11:40 +0200
            Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-22 11:50 +0200
            Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 04:20 +0200
              Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 08:10 +0200
              Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-23 12:30 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 04:10 +0200
                Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 09:40 +0200
        Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Dave Chinner <david@fromorbit.com> - 2017-08-22 23:20 +0200
        Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 04:40 +0200
          Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 08:20 +0200
          Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Peter Zijlstra <peterz@infradead.org> - 2017-08-23 12:50 +0200
            Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-24 07:10 +0200
      Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all  part of PROVE_LOCKING Byungchul Park <byungchul.park@lge.com> - 2017-08-23 04:00 +0200

csiph-web