Re: [PATCH 0/4] constify scsi/tty parisc_device_id

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Helge Deller <deller@gmx.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/4] constify scsi/tty parisc_device_id
Date	Mon, 21 Aug 2017 22:50:02 +0200
Message-ID	<uh1O2-GL-9@gated-at.bofh.it> (permalink)
References	<uggcp-4iI-11@gated-at.bofh.it>
X-Original-To	Arvind Yadav <arvind.yadav.cs@gmail.com>, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, gregkh@linuxfoundation.org, jslaby@suse.com
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Language	en-US
Content-Transfer-Encoding	7bit
X-Provags-ID	V03:K0:/GD87DECnCEzjWmXDFJvZOWg+2nlA8QyfX6cGQVrO1zQdlrYdQm gTNuh1uY2GLT+cuURpQQpCita46X9NZx+TiY7XnAChVWpuX/mj2PKgIWI6Utbzf7qyz8vkj YWMPQczrRpVcn6awwFsGA2NSxiYad1vv5RmIvRrRaw0J5Wtr9G2NgX3dAZ9f4yqmGSA597N v0kwFCF0Dwg/TP2LFQjzw==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:xCuopH6H5ks=:eLZy47Ykl05COKVahjze6d 4i/5tbqoCfo7vcrVfk/vLgb4Cx3BfT7TmX9+ShZDd+41UjLvkvC9mvjxuGP8at8jgLx0Ep2Xb QSAcSLCYBBApsSvzh/1QkGBvQ6vz7js+O/XtIi6GMa49C25JHYiQHEuMHe/5I7/G4yY77K68J hjRG07J1lljW8tlMKyBsf/Tb4woZ3tNrKRIoffM9dbbrOH/uFajSDLdN0bCCNSzRN/ve6skvi G0JZWi5mMeg9zbRc/w2b0azIytac4ppJ+T/NNPtzzySVEd3re8JMimO6nhQHww+ZWe/lln5u6 L47SigngmEgeMN47fZeeakHogAJ6IvL3AHKtbiGxjzTabDezLRdgkQiCWJFEmFvVVh9ZiOOru 7GM7MT1hYYdKqA8D8XirnCNKS0S8jPmcNGbLQUKDHk2UgmcSUjvSoJaevreL2PLiYA4FIr5CW l2vppj2i2PRMpNvRn89SNNxyNRiOePr4TRvADwXY9YLIqD40SS8nR/Ui1h+BUbTF6CswO29UH 5NVE0YtRnN+rrHKK0UyNYuF5iBFWEPbVUFZx1Gp3KoCF0TClBqPaLx7mEOuO3i6TjizXUqHZH 8+YkB3V8Ty9xRlbPvlNsHpoWEKJyKFqx75+/DMopMizxaDbxsh2+WU+kfiX0WsB6ncEeQWPsG 7c5cC4o7msbjWuL+KtJT02oU4XSfuUISwxqeNtgzuQ4tFD5CMbMkWur6BL0L+dJMP9muGfbme hnj6gBEwHAsxFIk+zoSB6U1HSz1eIbawVl3kG3mj+4TbXgXO90FalCMf8skTDXpOHqGbvQRHl xV1y5xkObcELoI71EGSLCwdpFjKwFfKIL004DhvPboB/WVQVkk=
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	26
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-scsi@vger.kernel.org
X-Original-Date	Mon, 21 Aug 2017 22:43:39 +0200
X-Original-Message-ID	<12d14a03-5734-9b97-fff0-f8fe7158ce63@gmx.de>
X-Original-References	<1503165261-31741-1-git-send-email-arvind.yadav.cs@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1716868

Show key headers only | View raw

On 19.08.2017 19:54, Arvind Yadav wrote:
> parisc_device_id are not supposed to change at runtime. All functions
> working with parisc_device_id provided by <asm/parisc-device.h> work with
> const parisc_device_id. So mark the non-const structs as const.
> 
> Arvind Yadav (4):
>   [PATCH 1/4] scsi: lasi700: constify parisc_device_id
>   [PATCH 2/4] scsi: zalon: constify parisc_device_id
>   [PATCH 3/4] tty: 8250: constify parisc_device_id
>   [PATCH 4/4] tty: mux: constify parisc_device_id

NAK.
Please don't apply.
I have other patches in my tree which will move those consts
into __init sections instead.

Thanks,
Helge

 
>  drivers/scsi/lasi700.c             | 2 +-
>  drivers/scsi/zalon.c               | 2 +-
>  drivers/tty/serial/8250/8250_gsc.c | 4 ++--
>  drivers/tty/serial/mux.c           | 4 ++--
>  4 files changed, 6 insertions(+), 6 deletions(-)
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] constify scsi/tty parisc_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 20:00 +0200
  [PATCH 2/4] scsi: zalon: constify parisc_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 20:00 +0200
  Re: [PATCH 0/4] constify scsi/tty parisc_device_id Helge Deller <deller@gmx.de> - 2017-08-21 22:50 +0200

csiph-web