Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1716868

Re: [PATCH 0/4] constify scsi/tty parisc_device_id

From Helge Deller <deller@gmx.de>
Newsgroups linux.kernel
Subject Re: [PATCH 0/4] constify scsi/tty parisc_device_id
Date 2017-08-21 22:50 +0200
Message-ID <uh1O2-GL-9@gated-at.bofh.it> (permalink)
References <uggcp-4iI-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 19.08.2017 19:54, Arvind Yadav wrote:
> parisc_device_id are not supposed to change at runtime. All functions
> working with parisc_device_id provided by <asm/parisc-device.h> work with
> const parisc_device_id. So mark the non-const structs as const.
> 
> Arvind Yadav (4):
>   [PATCH 1/4] scsi: lasi700: constify parisc_device_id
>   [PATCH 2/4] scsi: zalon: constify parisc_device_id
>   [PATCH 3/4] tty: 8250: constify parisc_device_id
>   [PATCH 4/4] tty: mux: constify parisc_device_id

NAK.
Please don't apply.
I have other patches in my tree which will move those consts
into __init sections instead.

Thanks,
Helge

 
>  drivers/scsi/lasi700.c             | 2 +-
>  drivers/scsi/zalon.c               | 2 +-
>  drivers/tty/serial/8250/8250_gsc.c | 4 ++--
>  drivers/tty/serial/mux.c           | 4 ++--
>  4 files changed, 6 insertions(+), 6 deletions(-)
> 

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] constify scsi/tty parisc_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 20:00 +0200
  [PATCH 2/4] scsi: zalon: constify parisc_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 20:00 +0200
  Re: [PATCH 0/4] constify scsi/tty parisc_device_id Helge Deller <deller@gmx.de> - 2017-08-21 22:50 +0200

csiph-web