Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1715712 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-08-19 20:00 +0200 |
| Last post | 2017-08-21 22:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/4] constify scsi/tty parisc_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 20:00 +0200
[PATCH 2/4] scsi: zalon: constify parisc_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 20:00 +0200
Re: [PATCH 0/4] constify scsi/tty parisc_device_id Helge Deller <deller@gmx.de> - 2017-08-21 22:50 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-19 20:00 +0200 |
| Subject | [PATCH 0/4] constify scsi/tty parisc_device_id |
| Message-ID | <uggcp-4iI-11@gated-at.bofh.it> |
parisc_device_id are not supposed to change at runtime. All functions working with parisc_device_id provided by <asm/parisc-device.h> work with const parisc_device_id. So mark the non-const structs as const. Arvind Yadav (4): [PATCH 1/4] scsi: lasi700: constify parisc_device_id [PATCH 2/4] scsi: zalon: constify parisc_device_id [PATCH 3/4] tty: 8250: constify parisc_device_id [PATCH 4/4] tty: mux: constify parisc_device_id drivers/scsi/lasi700.c | 2 +- drivers/scsi/zalon.c | 2 +- drivers/tty/serial/8250/8250_gsc.c | 4 ++-- drivers/tty/serial/mux.c | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) -- 2.7.4
[toc] | [next] | [standalone]
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-19 20:00 +0200 |
| Subject | [PATCH 2/4] scsi: zalon: constify parisc_device_id |
| Message-ID | <uggcq-4iI-15@gated-at.bofh.it> |
| In reply to | #1715712 |
parisc_device_id are not supposed to change at runtime. All functions
working with parisc_device_id provided by <asm/parisc-device.h> work
with const parisc_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/zalon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/zalon.c b/drivers/scsi/zalon.c
index b2cf1fa..00c7c28 100644
--- a/drivers/scsi/zalon.c
+++ b/drivers/scsi/zalon.c
@@ -160,7 +160,7 @@ zalon_probe(struct parisc_device *dev)
return error;
}
-static struct parisc_device_id zalon_tbl[] = {
+static const struct parisc_device_id zalon_tbl[] = {
{ HPHW_A_DMA, HVERSION_REV_ANY_ID, HVERSION_ANY_ID, 0x00089 },
{ 0, }
};
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Helge Deller <deller@gmx.de> |
|---|---|
| Date | 2017-08-21 22:50 +0200 |
| Message-ID | <uh1O2-GL-9@gated-at.bofh.it> |
| In reply to | #1715712 |
On 19.08.2017 19:54, Arvind Yadav wrote: > parisc_device_id are not supposed to change at runtime. All functions > working with parisc_device_id provided by <asm/parisc-device.h> work with > const parisc_device_id. So mark the non-const structs as const. > > Arvind Yadav (4): > [PATCH 1/4] scsi: lasi700: constify parisc_device_id > [PATCH 2/4] scsi: zalon: constify parisc_device_id > [PATCH 3/4] tty: 8250: constify parisc_device_id > [PATCH 4/4] tty: mux: constify parisc_device_id NAK. Please don't apply. I have other patches in my tree which will move those consts into __init sections instead. Thanks, Helge > drivers/scsi/lasi700.c | 2 +- > drivers/scsi/zalon.c | 2 +- > drivers/tty/serial/8250/8250_gsc.c | 4 ++-- > drivers/tty/serial/mux.c | 4 ++-- > 4 files changed, 6 insertions(+), 6 deletions(-) >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web