Re: [PATCH] sched/fair: move definitions to fix !CONFIG_SMP

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Josef Bacik <josef@toxicpanda.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sched/fair: move definitions to fix !CONFIG_SMP
Date	Mon, 21 Aug 2017 22:50:02 +0200
Message-ID	<uh1O2-GL-3@gated-at.bofh.it> (permalink)
References	<uh1bj-tH-9@gated-at.bofh.it> <uh1bj-tH-7@gated-at.bofh.it>
X-Original-To	Peter Zijlstra <peterz@infradead.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1NsNOU8rZvsRXlPvNwm1yIwEeSBK9Izw9EMwgh/dh4o=; b=HiBDhiThZjOK+kMcA9Tsc+TfX8JapGrA5VARVa+ts/tdo0nepvPa5ODLhWVDVfftKn j8ZOPat2oukVvT3bOvo74d74Ax85H2uXw34p4xuO58RLe6tS1lFE7JaHYWcDEHgEnZ/a t3vv2DQiK7n7DY8bBbWxrA4ldvbFLTkN2xzpN/UQtGCoUiHe7ClUi8CwQN/Un2LlEra+ L57AQMkrtfJlPCJFhjdBaMsMqeAS6IA/N5QEIDvPSTiCOMtYdWv0VFS1tBzqPhRuJlGN lqH9EtUw1hzdNbmaEKc+sJ3S6MpS7eb3yeiHkqK7gUT1leIyaYiYzOKdYxa6w73lKWhv Ss6A==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1NsNOU8rZvsRXlPvNwm1yIwEeSBK9Izw9EMwgh/dh4o=; b=G/7EQ8vVFvMwML9uwuGIq+deSKu7VXOFQWN96r2v44AdC4qHXFe1L3neQswBhfU010 KQBFPoyQOEELoJhY6gmpkMmusCKJ6E4hxsF0xfQtgw/LNNz5yqTWOph+FH1aX3XqQ5Wu CI12C7B8jScDBCDZQ9F6AcHC7kmHn62rOL4DQfpzZ0l0hmdyhG1/tP780T8LJVy1Mstp VkzEusjiv9fw368IDt3yFH85cVQGQWo9dGajqeiEg73Ce711zfDj452W6Z1vo++JjeWb IhZB2Gyztp1WIZwiPeLB3xahJWXIQu5X0PuuJQpHF3WHnBPPGEmShTc1eupc6kTHtrGf r5tg==
X-Gm-Message-State	AHYfb5hGK+4vO6T8jsehZEUFexdc9+JVa7lF7062Qli1sGQ3TGKpyQz3 Bj2QBVG6sK2+Zykn
X-Received	by 10.55.123.133 with SMTP id w127mr24130659qkc.79.1503348280669; Mon, 21 Aug 2017 13:44:40 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.8.0 (2017-02-23)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
Organization	linux.* mail to news gateway
X-Original-Cc	josef@toxicpanda.com, linux-kernel@vger.kernel.org, kernel-team@fb.com, Josef Bacik <jbacik@fb.com>
X-Original-Date	Mon, 21 Aug 2017 16:44:39 -0400
X-Original-Message-ID	<20170821204438.GI23807@destiny>
X-Original-References	<1503345785-9323-1-git-send-email-jbacik@fb.com> <20170821200653.GC32112@worktop.programming.kicks-ass.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1716866

Show key headers only | View raw

On Mon, Aug 21, 2017 at 10:06:53PM +0200, Peter Zijlstra wrote:
> On Mon, Aug 21, 2017 at 04:03:05PM -0400, josef@toxicpanda.com wrote:
> > From: Josef Bacik <jbacik@fb.com>
> > 
> > The series of patches adding runnable_avg and subsequent supporting
> > patches broke on !CONFIG_SMP.  Fix this by moving the definitions under
> > the appropriate checks, and moving the !CONFIG_SMP definitions higher
> > up.
> 
> Is this on top or can I fold this in somewhere? I was meaning to rework
> the series to avoid this superfluous build borkage.

There's actually a lot of individual breakages.  I can go through and make
individual patches that can be folded in to where they were introduced, or I can
do them all at once.  There's breakage around !CONFIG_FAIR_GROUP_SCHED as well,
basically everything you added needs to be moved around some.  I'll do whatever
is most convenient for you.  Thanks,

Josef

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] sched/fair: move definitions to fix !CONFIG_SMP Peter Zijlstra <peterz@infradead.org> - 2017-08-21 22:10 +0200
  Re: [PATCH] sched/fair: move definitions to fix !CONFIG_SMP Josef Bacik <josef@toxicpanda.com> - 2017-08-21 22:50 +0200

csiph-web