Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1716831 > unrolled thread

Re: [PATCH] sched/fair: move definitions to fix !CONFIG_SMP

Started byPeter Zijlstra <peterz@infradead.org>
First post2017-08-21 22:10 +0200
Last post2017-08-21 22:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] sched/fair: move definitions to fix !CONFIG_SMP Peter Zijlstra <peterz@infradead.org> - 2017-08-21 22:10 +0200
    Re: [PATCH] sched/fair: move definitions to fix !CONFIG_SMP Josef Bacik <josef@toxicpanda.com> - 2017-08-21 22:50 +0200

#1716831 — Re: [PATCH] sched/fair: move definitions to fix !CONFIG_SMP

FromPeter Zijlstra <peterz@infradead.org>
Date2017-08-21 22:10 +0200
SubjectRe: [PATCH] sched/fair: move definitions to fix !CONFIG_SMP
Message-ID<uh1bj-tH-7@gated-at.bofh.it>
On Mon, Aug 21, 2017 at 04:03:05PM -0400, josef@toxicpanda.com wrote:
> From: Josef Bacik <jbacik@fb.com>
> 
> The series of patches adding runnable_avg and subsequent supporting
> patches broke on !CONFIG_SMP.  Fix this by moving the definitions under
> the appropriate checks, and moving the !CONFIG_SMP definitions higher
> up.

Is this on top or can I fold this in somewhere? I was meaning to rework
the series to avoid this superfluous build borkage.

[toc] | [next] | [standalone]


#1716866

FromJosef Bacik <josef@toxicpanda.com>
Date2017-08-21 22:50 +0200
Message-ID<uh1O2-GL-3@gated-at.bofh.it>
In reply to#1716831
On Mon, Aug 21, 2017 at 10:06:53PM +0200, Peter Zijlstra wrote:
> On Mon, Aug 21, 2017 at 04:03:05PM -0400, josef@toxicpanda.com wrote:
> > From: Josef Bacik <jbacik@fb.com>
> > 
> > The series of patches adding runnable_avg and subsequent supporting
> > patches broke on !CONFIG_SMP.  Fix this by moving the definitions under
> > the appropriate checks, and moving the !CONFIG_SMP definitions higher
> > up.
> 
> Is this on top or can I fold this in somewhere? I was meaning to rework
> the series to avoid this superfluous build borkage.

There's actually a lot of individual breakages.  I can go through and make
individual patches that can be folded in to where they were introduced, or I can
do them all at once.  There's breakage around !CONFIG_FAIR_GROUP_SCHED as well,
basically everything you added needs to be moved around some.  I'll do whatever
is most convenient for you.  Thanks,

Josef

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web