Path: csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From: Josef Bacik <josef@toxicpanda.com>
Newsgroups: linux.kernel
Subject: Re: [PATCH] sched/fair: move definitions to fix !CONFIG_SMP
Date: Mon, 21 Aug 2017 22:50:02 +0200
Message-ID: <uh1O2-GL-3@gated-at.bofh.it>
References: <uh1bj-tH-9@gated-at.bofh.it> <uh1bj-tH-7@gated-at.bofh.it>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: robomod@news.nic.it
Approved: robomod@news.nic.it
Lines: 19
Organization: linux.* mail to news gateway
Xref: csiph.com linux.kernel:1716866

On Mon, Aug 21, 2017 at 10:06:53PM +0200, Peter Zijlstra wrote:
> On Mon, Aug 21, 2017 at 04:03:05PM -0400, josef@toxicpanda.com wrote:
> > From: Josef Bacik <jbacik@fb.com>
> > 
> > The series of patches adding runnable_avg and subsequent supporting
> > patches broke on !CONFIG_SMP.  Fix this by moving the definitions under
> > the appropriate checks, and moving the !CONFIG_SMP definitions higher
> > up.
> 
> Is this on top or can I fold this in somewhere? I was meaning to rework
> the series to avoid this superfluous build borkage.

There's actually a lot of individual breakages.  I can go through and make
individual patches that can be folded in to where they were introduced, or I can
do them all at once.  There's breakage around !CONFIG_FAIR_GROUP_SCHED as well,
basically everything you added needs to be moved around some.  I'll do whatever
is most convenient for you.  Thanks,

Josef