Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1715880

[PATCH 10/12] ASoC: sun4i-codec: Remove unnecessary function call

Path csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From Peng Donglin <dolinux.peng@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 10/12] ASoC: sun4i-codec: Remove unnecessary function call
Date Sun, 20 Aug 2017 08:00:01 +0200
Message-ID <ugrrb-2SW-3@gated-at.bofh.it> (permalink)
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=9MQ4toGIg5PlBuI36O++PhqzJpXFVRChibNH4/e0CmE=; b=umZC4PZXPzBnD9uSTqn8pgFcDr74wwVBoew6vO7ieH7ZnSPCtbFQ33bZJm+4GsWRYZ lKOvhi3RWBHwJEsdo0oUYWYrJGvJXj7GNru+yRaYtaNOltbcOMYIyjAwRf3UWoubUpHY DXyK9511i9CaTeV/dwTkAxEIjCyEwyAseL0AzxWNACSKP23wZAhrLausrv5fQi958aCp naY4yHpAdnx7d9sXBnT9SYAawbH5RN8djicx4iy9H+89eMbo3ucgUGju6J+pA9nHRGn0 DPsKyHO6+X+reQEHY9DPFdj66fq94h5TfC7f3p+LNkFHcEbEyqlemOnNVzVZqBQWr3k+ 9w/w==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9MQ4toGIg5PlBuI36O++PhqzJpXFVRChibNH4/e0CmE=; b=GmF4EEgpeTj/mt0RUTewZhG/oJJqXl1ynAYfiIZ1JOM+9flqxBEz2BM7clgQuBV53v 1QMAavF0xEw9Qa3TXjYtQaZXKPMFp23YxaJd6eh1hQkRj+rcJHkEnafURAz6swI2sF5L kD0eFnHhyInbPObk8bpZgvc0r6UB2rjo5BK5vfn9xLwUhXhHpJFbUSzeTffBUewO6hXu rLkUUAZa3ARx8zvhVq9KXysWDGHE/mn1yGn2YULyBIWeQKb42Cn13lQ6otocyfNuWsBr t9NezD1f4+RtlH4380XVxZrY+9MX0KlAL0zyXd0mus8k9MM/FsZAENi5FZnQPLkIt6Vv mO9w==
X-Gm-Message-State AHYfb5jMkqQEM03CrLg6EGtGOD0Ial2puNbNdOLf87ctMEBoD6QQlXIY ORR5NzTuXDYXeQ==
X-Received by 10.84.210.171 with SMTP id a40mr14928682pli.443.1503208518906; Sat, 19 Aug 2017 22:55:18 -0700 (PDT)
X-Mailer git-send-email 1.9.1
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 26
Organization linux.* mail to news gateway
X-Original-Cc alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Donglin <dolinux.peng@gmail.com>
X-Original-Date Sun, 20 Aug 2017 13:55:13 +0800
X-Original-Message-ID <1503208513-4015-1-git-send-email-dolinux.peng@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1715880

Show key headers only | View raw


First of all,the address of pdev->dev is assigned to card->dev in
create_card,then the function platform_set_drvdata copies the value
the variable card to pdev->dev.driver_data, but when calling
snd_soc_register_card,the function dev_set_drvdata(card->dev, card)
will also do the same copy operation,so i think that the former copy
operation can be removed.

Signed-off-by: Peng Donglin <dolinux.peng@gmail.com>
---
 sound/soc/sunxi/sun4i-codec.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c
index 1500699..82beeae 100644
--- a/sound/soc/sunxi/sun4i-codec.c
+++ b/sound/soc/sunxi/sun4i-codec.c
@@ -1655,7 +1655,6 @@ static int sun4i_codec_probe(struct platform_device *pdev)
 		goto err_unregister_codec;
 	}
 
-	platform_set_drvdata(pdev, card);
 	snd_soc_card_set_drvdata(card, scodec);
 
 	ret = snd_soc_register_card(card);
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 10/12] ASoC: sun4i-codec: Remove unnecessary function call Peng Donglin <dolinux.peng@gmail.com> - 2017-08-20 08:00 +0200

csiph-web