Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1715881
| From | Peng Donglin <dolinux.peng@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 12/12] ASoC: ux500: Remove unnecessary function call |
| Date | 2017-08-20 08:10 +0200 |
| Message-ID | <ugrAR-3bi-1@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
First of all,the address of pdev->dev is assigned to mop500_card.dev, then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data,but when calling snd_soc_register_card, the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed. Signed-off-by: Peng Donglin <dolinux.peng@gmail.com> --- sound/soc/ux500/mop500.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/ux500/mop500.c b/sound/soc/ux500/mop500.c index ba9fc09..070a688 100644 --- a/sound/soc/ux500/mop500.c +++ b/sound/soc/ux500/mop500.c @@ -115,7 +115,6 @@ static int mop500_probe(struct platform_device *pdev) dev_dbg(&pdev->dev, "%s: Card %s: Set platform drvdata.\n", __func__, mop500_card.name); - platform_set_drvdata(pdev, &mop500_card); snd_soc_card_set_drvdata(&mop500_card, NULL); -- 1.9.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 12/12] ASoC: ux500: Remove unnecessary function call Peng Donglin <dolinux.peng@gmail.com> - 2017-08-20 08:10 +0200 Applied "ASoC: ux500: Remove unnecessary function call" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-08-21 19:30 +0200
csiph-web