[PATCH 09/12] ASoC: qcom: Remove unnecessary function call

From	Peng Donglin <dolinux.peng@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 09/12] ASoC: qcom: Remove unnecessary function call
Date	2017-08-20 07:50 +0200
Message-ID	<ugrhv-2PX-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

First of all,the address of pdev->dev is assigned to card->dev,then
the function platform_set_drvdata copies the value the variable card
to pdev->dev.driver_data, but when calling snd_soc_register_card,the
function dev_set_drvdata(card->dev, card) will also do the same copy
operation,so i think that the former copy operation can be removed.

Signed-off-by: Peng Donglin <dolinux.peng@gmail.com>
---
 sound/soc/qcom/storm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/qcom/storm.c b/sound/soc/qcom/storm.c
index c5207af..a9fa972 100644
--- a/sound/soc/qcom/storm.c
+++ b/sound/soc/qcom/storm.c
@@ -99,7 +99,6 @@ static int storm_platform_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	card->dev = &pdev->dev;
-	platform_set_drvdata(pdev, card);
 
 	ret = snd_soc_of_parse_card_name(card, "qcom,model");
 	if (ret) {
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 09/12] ASoC: qcom: Remove unnecessary function call Peng Donglin <dolinux.peng@gmail.com> - 2017-08-20 07:50 +0200
  Re: [alsa-devel] [PATCH 09/12] ASoC: qcom: Remove unnecessary  function call Banajit Goswami <bgoswami@codeaurora.org> - 2017-08-21 10:20 +0200

csiph-web