Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1715878
| From | Peng Donglin <dolinux.peng@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 08/12] ASoC: qcom: Remove useless function call |
| Date | 2017-08-20 07:50 +0200 |
| Message-ID | <ugrhv-2PX-1@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
The function platform_set_drvdata(pdev, data) copies the value of the variable data to pdev->dev.driver_data,but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will override it, so i think that the former copy operation is useless and can be removed. Signed-off-by: Peng Donglin <dolinux.peng@gmail.com> --- sound/soc/qcom/apq8016_sbc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/qcom/apq8016_sbc.c b/sound/soc/qcom/apq8016_sbc.c index d084d74..5292591 100644 --- a/sound/soc/qcom/apq8016_sbc.c +++ b/sound/soc/qcom/apq8016_sbc.c @@ -191,7 +191,6 @@ static int apq8016_sbc_platform_probe(struct platform_device *pdev) if (IS_ERR(data->spkr_iomux)) return PTR_ERR(data->spkr_iomux); - platform_set_drvdata(pdev, data); snd_soc_card_set_drvdata(card, data); return devm_snd_soc_register_card(&pdev->dev, card); -- 1.9.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 08/12] ASoC: qcom: Remove useless function call Peng Donglin <dolinux.peng@gmail.com> - 2017-08-20 07:50 +0200 Re: [alsa-devel] [PATCH 08/12] ASoC: qcom: Remove useless function call Banajit Goswami <bgoswami@codeaurora.org> - 2017-08-21 10:10 +0200
csiph-web