Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1715878 > unrolled thread
| Started by | Peng Donglin <dolinux.peng@gmail.com> |
|---|---|
| First post | 2017-08-20 07:50 +0200 |
| Last post | 2017-08-21 10:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 08/12] ASoC: qcom: Remove useless function call Peng Donglin <dolinux.peng@gmail.com> - 2017-08-20 07:50 +0200
Re: [alsa-devel] [PATCH 08/12] ASoC: qcom: Remove useless function call Banajit Goswami <bgoswami@codeaurora.org> - 2017-08-21 10:10 +0200
| From | Peng Donglin <dolinux.peng@gmail.com> |
|---|---|
| Date | 2017-08-20 07:50 +0200 |
| Subject | [PATCH 08/12] ASoC: qcom: Remove useless function call |
| Message-ID | <ugrhv-2PX-1@gated-at.bofh.it> |
The function platform_set_drvdata(pdev, data) copies the value of the variable data to pdev->dev.driver_data,but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will override it, so i think that the former copy operation is useless and can be removed. Signed-off-by: Peng Donglin <dolinux.peng@gmail.com> --- sound/soc/qcom/apq8016_sbc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/qcom/apq8016_sbc.c b/sound/soc/qcom/apq8016_sbc.c index d084d74..5292591 100644 --- a/sound/soc/qcom/apq8016_sbc.c +++ b/sound/soc/qcom/apq8016_sbc.c @@ -191,7 +191,6 @@ static int apq8016_sbc_platform_probe(struct platform_device *pdev) if (IS_ERR(data->spkr_iomux)) return PTR_ERR(data->spkr_iomux); - platform_set_drvdata(pdev, data); snd_soc_card_set_drvdata(card, data); return devm_snd_soc_register_card(&pdev->dev, card); -- 1.9.1
[toc] | [next] | [standalone]
| From | Banajit Goswami <bgoswami@codeaurora.org> |
|---|---|
| Date | 2017-08-21 10:10 +0200 |
| Subject | Re: [alsa-devel] [PATCH 08/12] ASoC: qcom: Remove useless function call |
| Message-ID | <ugPWx-1LA-1@gated-at.bofh.it> |
| In reply to | #1715878 |
On Sun, Aug 20, 2017 at 01:43:57PM +0800, Peng Donglin wrote: > The function platform_set_drvdata(pdev, data) copies the value of > the variable data to pdev->dev.driver_data,but when calling > snd_soc_register_card,the function dev_set_drvdata(card->dev, card) > will override it, so i think that the former copy operation is > useless and can be removed. > > Signed-off-by: Peng Donglin <dolinux.peng@gmail.com> Acked-by: Banajit Goswami <bgoswami@codeaurora.org> > --- > sound/soc/qcom/apq8016_sbc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/soc/qcom/apq8016_sbc.c b/sound/soc/qcom/apq8016_sbc.c > index d084d74..5292591 100644 > --- a/sound/soc/qcom/apq8016_sbc.c > +++ b/sound/soc/qcom/apq8016_sbc.c > @@ -191,7 +191,6 @@ static int apq8016_sbc_platform_probe(struct platform_device *pdev) > if (IS_ERR(data->spkr_iomux)) > return PTR_ERR(data->spkr_iomux); > > - platform_set_drvdata(pdev, data); > snd_soc_card_set_drvdata(card, data); > > return devm_snd_soc_register_card(&pdev->dev, card); > -- > 1.9.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web