Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	"santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create
Date	Mon, 21 Aug 2017 07:50:02 +0200
Message-ID	<ugNL4-eO-7@gated-at.bofh.it> (permalink)
References	<u9aEN-1Ca-7@gated-at.bofh.it>
X-Original-To	"arm@kernel.org" <arm@kernel.org>, Arnd Bergmann <arnd@arndb.de>
Organization	Oracle Corporation
User-Agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8; format=flowed
Content-Language	en-US
Content-Transfer-Encoding	7bit
X-Source-IP	aserv0022.oracle.com [141.146.126.234]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	17
X-Original-Cc	Keerthy <j-keerthy@ti.com>, ssantosh@kernel.org, m-karicheri2@ti.com, t-kristo@ti.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Sun, 20 Aug 2017 22:44:51 -0700
X-Original-Message-ID	<2f826631-68d2-6a7e-a656-9c8e67ee8337@oracle.com>
X-Original-References	<1501475496-10267-1-git-send-email-j-keerthy@ti.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1716097

Show key headers only | View raw

Hi Arnd,

On 7/30/17 9:31 PM, Keerthy wrote:
> knav_pool_create is an exported function. In the event of a call
> before knav_queue_probe, we encounter a NULL pointer dereference
> in the following line. Hence return -EPROBE_DEFER to the caller till
> the kdev pointer is non-NULL.
> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> 
> Changes in v2:
> 
>    * Fixed returning an int to returning pointer.
FWIW, Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>

Can you please also apply this fix in your fixes branch ?

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in  knav_pool_create "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> - 2017-08-21 07:50 +0200
  Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create Arnd Bergmann <arnd@arndb.de> - 2017-08-21 09:30 +0200

csiph-web