Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1716097 > unrolled thread
| Started by | "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> |
|---|---|
| First post | 2017-08-21 07:50 +0200 |
| Last post | 2017-08-21 09:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> - 2017-08-21 07:50 +0200
Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create Arnd Bergmann <arnd@arndb.de> - 2017-08-21 09:30 +0200
| From | "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> |
|---|---|
| Date | 2017-08-21 07:50 +0200 |
| Subject | Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create |
| Message-ID | <ugNL4-eO-7@gated-at.bofh.it> |
Hi Arnd, On 7/30/17 9:31 PM, Keerthy wrote: > knav_pool_create is an exported function. In the event of a call > before knav_queue_probe, we encounter a NULL pointer dereference > in the following line. Hence return -EPROBE_DEFER to the caller till > the kdev pointer is non-NULL. > > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- > > Changes in v2: > > * Fixed returning an int to returning pointer. FWIW, Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com> Can you please also apply this fix in your fixes branch ?
[toc] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-08-21 09:30 +0200 |
| Subject | Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create |
| Message-ID | <ugPjQ-1iz-3@gated-at.bofh.it> |
| In reply to | #1716097 |
On Mon, Aug 21, 2017 at 7:44 AM, santosh.shilimkar@oracle.com
<santosh.shilimkar@oracle.com> wrote:
> Hi Arnd,
>
> On 7/30/17 9:31 PM, Keerthy wrote:
>>
>> knav_pool_create is an exported function. In the event of a call
>> before knav_queue_probe, we encounter a NULL pointer dereference
>> in the following line. Hence return -EPROBE_DEFER to the caller till
>> the kdev pointer is non-NULL.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>
>> Changes in v2:
>>
>> * Fixed returning an int to returning pointer.
>
> FWIW, Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
>
> Can you please also apply this fix in your fixes branch ?
Applied now, thanks!
Arnd
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web