Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create

From	"santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create
Date	2017-08-21 07:50 +0200
Message-ID	<ugNL4-eO-7@gated-at.bofh.it> (permalink)
References	<u9aEN-1Ca-7@gated-at.bofh.it>
Organization	Oracle Corporation

Show all headers | View raw

Hi Arnd,

On 7/30/17 9:31 PM, Keerthy wrote:
> knav_pool_create is an exported function. In the event of a call
> before knav_queue_probe, we encounter a NULL pointer dereference
> in the following line. Hence return -EPROBE_DEFER to the caller till
> the kdev pointer is non-NULL.
> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> 
> Changes in v2:
> 
>    * Fixed returning an int to returning pointer.
FWIW, Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>

Can you please also apply this fix in your fixes branch ?

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in  knav_pool_create "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> - 2017-08-21 07:50 +0200
  Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create Arnd Bergmann <arnd@arndb.de> - 2017-08-21 09:30 +0200

csiph-web