Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1712779

Re: [PATCH 2/3] crypto: engine - find request type with cra_type

From Corentin Labbe <clabbe.montjoie@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] crypto: engine - find request type with cra_type
Date 2017-08-16 11:00 +0200
Message-ID <uf2lb-4Su-9@gated-at.bofh.it> (permalink)
References <uenrI-4CX-3@gated-at.bofh.it> <uenBn-4G7-3@gated-at.bofh.it> <ueEVA-6Vl-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Aug 15, 2017 at 07:51:14AM +0000, Fabien DESSENNE wrote:
> Hi Corentin,
> 
> Since I have just sent a patch to add the support of "aead_request" to crypto engine, I am wondering if your proposed change (checking cra_type instead of crypto_tfm_alg_type) and mine are compatible.
> It looks like they are (assuming we export crypto_aead_type): can you confirm?
> BR
> 
> Fabien.
> 

Hello

My change is incompatible with yours since I remove a switch(crypto_tfm_alg_type) that you use.
Anyway you will need my change:) because you use ablkcipher which is obsolete and you need to convert to skcipher.

regards
Corentin Labbe

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3 v3] crypto: engine - Permit to enqueue skcipher request Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-14 15:20 +0200
  [PATCH 3/3] crypto: engine - Permit to enqueue skcipher request Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-14 15:20 +0200
  [PATCH 2/3] crypto: engine - find request type with cra_type Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-14 15:30 +0200
    RE: [PATCH 2/3] crypto: engine - find request type with cra_type Fabien DESSENNE <fabien.dessenne@st.com> - 2017-08-15 10:00 +0200
      Re: [PATCH 2/3] crypto: engine - find request type with cra_type Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-16 11:00 +0200
    Re: [PATCH 2/3] crypto: engine - find request type with cra_type Herbert Xu <herbert@gondor.apana.org.au> - 2017-08-18 10:30 +0200
      Re: [PATCH 2/3] crypto: engine - find request type with cra_type Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-18 13:50 +0200
  [PATCH 1/3] crypto: skcipher - export crypto_skcipher_type2 Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-14 15:30 +0200

csiph-web