Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1712778

[PATCH resend] thunderbolt: Fix reset response_type

Show all headers | View raw

There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET)
instead of just TB_CFG_PKG_RESET.  The size of an int is 4 so it's the
same as TB_CFG_PKG_NOTIFY_ACK.

Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable")
Reported-by: Colin King <colin.king@canonical.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
Resending with Greg CC'd.  This was also:
Signed-off-by: Andreas Noever <andreas.noever@gmail.com>
But I wasn't sure if I should add that tag.

diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c
index 69c0232a22f8..fb40dd0588b9 100644
--- a/drivers/thunderbolt/ctl.c
+++ b/drivers/thunderbolt/ctl.c
@@ -804,7 +804,7 @@ struct tb_cfg_result tb_cfg_reset(struct tb_ctl *ctl, u64 route,
 	req->request_type = TB_CFG_PKG_RESET;
 	req->response = &reply;
 	req->response_size = sizeof(reply);
-	req->response_type = sizeof(TB_CFG_PKG_RESET);
+	req->response_type = TB_CFG_PKG_RESET;
 
 	res = tb_cfg_request_sync(ctl, req, timeout_msec);
 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] thunderbolt: fix incorrect value assigned to req->response_type Colin King <colin.king@canonical.com> - 2017-08-15 16:40 +0200
  Re: [PATCH] thunderbolt: fix incorrect value assigned to  req->response_type Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-08-15 16:40 +0200
    Re: [PATCH] thunderbolt: fix incorrect value assigned to  req->response_type Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-15 17:30 +0200
      Re: [PATCH] thunderbolt: fix incorrect value assigned to  req->response_type Colin Ian King <colin.king@canonical.com> - 2017-08-15 17:50 +0200
        [PATCH resend] thunderbolt: Fix reset response_type Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-16 11:00 +0200
      Re: [PATCH] thunderbolt: fix incorrect value assigned to  req->response_type Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-08-16 10:20 +0200
        Re: [PATCH] thunderbolt: fix incorrect value assigned to  req->response_type Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-16 18:20 +0200
          Re: [PATCH] thunderbolt: fix incorrect value assigned to  req->response_type Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-08-17 11:50 +0200

csiph-web