Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1714681

Re: [PATCH 2/3] crypto: engine - find request type with cra_type

From Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] crypto: engine - find request type with cra_type
Date 2017-08-18 10:30 +0200
Message-ID <ufKPf-VO-7@gated-at.bofh.it> (permalink)
References <uenrI-4CX-3@gated-at.bofh.it> <uenBn-4G7-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Aug 14, 2017 at 03:17:24PM +0200, Corentin Labbe wrote:
> The current method for finding request type is based on crypto_tfm_alg_type.
> 
> But in case of skcipher, it is the same than ablkcipher.
> Using cra_type for this work permits to make the distinction between the two.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

I think you misunderstood my suggestion.  I'm not saying that
you should use cra_type to distinguish all crypto types, it should
only be used to distinguish ablkcipher from skcipher.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3 v3] crypto: engine - Permit to enqueue skcipher request Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-14 15:20 +0200
  [PATCH 3/3] crypto: engine - Permit to enqueue skcipher request Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-14 15:20 +0200
  [PATCH 2/3] crypto: engine - find request type with cra_type Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-14 15:30 +0200
    RE: [PATCH 2/3] crypto: engine - find request type with cra_type Fabien DESSENNE <fabien.dessenne@st.com> - 2017-08-15 10:00 +0200
      Re: [PATCH 2/3] crypto: engine - find request type with cra_type Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-16 11:00 +0200
    Re: [PATCH 2/3] crypto: engine - find request type with cra_type Herbert Xu <herbert@gondor.apana.org.au> - 2017-08-18 10:30 +0200
      Re: [PATCH 2/3] crypto: engine - find request type with cra_type Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-18 13:50 +0200
  [PATCH 1/3] crypto: skcipher - export crypto_skcipher_type2 Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-14 15:30 +0200

csiph-web