RE: [[PATCH v1] 30/37] [CIFS] SMBD: Add SMBDirect transport to Makefile

From	Tom Talpey <ttalpey@microsoft.com>
Newsgroups	linux.kernel
Subject	RE: [[PATCH v1] 30/37] [CIFS] SMBD: Add SMBDirect transport to Makefile
Date	2017-08-14 23:30 +0200
Message-ID	<uev5T-Rc-1@gated-at.bofh.it> (permalink)
References	<ua8hz-6jk-3@gated-at.bofh.it> <ua8hD-6jk-77@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs-
> owner@vger.kernel.org] On Behalf Of Long Li
> Sent: Wednesday, August 2, 2017 4:11 PM
> To: Steve French <sfrench@samba.org>; linux-cifs@vger.kernel.org; samba-
> technical@lists.samba.org; linux-kernel@vger.kernel.org
> Cc: Long Li <longli@microsoft.com>
> Subject: [[PATCH v1] 30/37] [CIFS] SMBD: Add SMBDirect transport to Makefile
> 
>  cifs-$(CONFIG_CIFS_SMB2) += smb2ops.o smb2maperror.o smb2transport.o \
> -                           smb2misc.o smb2pdu.o smb2inode.o smb2file.o
> +                           smb2misc.o smb2pdu.o smb2inode.o smb2file.o cifsrdma.o

"cifsrdma.o" is a really confusing choice of names. SMB Direct is only
possible when the negotiated SMB dialect is SMB3. "CIFS" historically
means a dialect of SMB1, which many of us would like to see be in
a separate, and therefore omittable, module. Please use a name
more indicative of the function, perhaps "smbdirect.o".

Tom.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

RE: [[PATCH v1] 30/37] [CIFS] SMBD: Add SMBDirect transport to  Makefile Tom Talpey <ttalpey@microsoft.com> - 2017-08-14 23:30 +0200
  RE: [[PATCH v1] 30/37] [CIFS] SMBD: Add SMBDirect transport to  Makefile Long Li <longli@microsoft.com> - 2017-08-15 01:40 +0200

csiph-web