Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Tom Talpey Newsgroups: linux.kernel Subject: RE: [[PATCH v1] 30/37] [CIFS] SMBD: Add SMBDirect transport to Makefile Date: Mon, 14 Aug 2017 23:30:01 +0200 Message-ID: References: Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YltlyqszTuqFbZytA5D6noz7Bifx/4XkGpcI+VzW+Zo=; b=EDXyJH43Ly+Rcd187yoPAPdAy1JvyYAAekBdNlLan480OqRMGunpGxnfx08xIAJDl1HXdz7fO77qBq3Vc7x1SJJELcM39kPE1hMdVXnZsrCho/4jm9r4fet22k/t2KEr4oSz3Bi8eJ+4dDF+GlpsFO8Ybi/H4HX8enqfr98ucCk= Thread-Topic: [[PATCH v1] 30/37] [CIFS] SMBD: Add SMBDirect transport to Makefile Thread-Index: AQHTC8vMTKT/LUVMlka32SUqep6z5aKEbbzA Accept-Language: en-US Content-Language: en-US X-Originating-IP: [24.218.182.144] X-Ms-Publictraffictype: Email X-Microsoft-Exchange-Diagnostics: 1;CY4PR21MB0136;6:eDmUzDLl3E/368/e8I8csppV+6r4cwH+sHoEtlFWoPn2kFGw8NCW2sRF4+hlWygQJo+JDqxh8vrYxlh4+3EOVObBU1x7XTtr5cN/804PE5FJky+XPG73B3PXYeqHsc0NrhDc59U+HSCWWFyPLGwzl/UZjf4Uv2T/YmRGVQFdtACJzs/u+RxdfdOOPqWHFYrsxFqlVbvAfO6GcOERE6VQyKQG6FI1hB/JWPCggq/3czZDTLKjceWDpMATb5oAy7s+ccou8y8umvwUPSZgbt2PjHJURod0IHV2Mnx3MhexjldnbaTg9zReigbHc1pDFTUvQnHjAwcrNvF+Wbx1XFlHOg==;5:OgoSRO1quK7V8KzqspHaUF6A9FATQ0z6OvHZmdmaWaso0W9iDVCd5wDfAJcF1NZpBwXKq7e5bAs4ibNCmLKj9aSKrxp4nfaBLouUHJayqcAzcP+L3NP3/9nqyRaFoV8AhEkz56IlPkfgFF1PjTKyhw==;24:oDmgSiQaMYkBzG/6pHQiAINbC78rI6NUHSGNG9nepc+pkN1XkGM2oqAFJf5Q2idQuK0WOjnSLGWY1kCS+q41DDooLAZzLSyUwiwO7rJpgJw=;7:zKQ+N0TOsjqSzdY8X0H4lPocAZ/ffQt6bD2NDvZuGEuY1um70RMVn+3+0ov5mvwQzUAHDt2O2PJpITVGcMksQcRtN0cv7x3bd+rvAfYIh/tMjeWAV4ebU/0sYvr+oudWbS/H4NsMUVwLKYRm4OMxM251ojVPoTTZtzmKonKPg26Qc35RINfv6U6Q8wUIO2Xz+Wp5MIT5eYQiQE0LbasacAzQUAnySjopcVMNSJlus0k= X-Ms-Office365-Filtering-Correlation-ID: a2677df5-e7a6-44df-20f2-08d4e35a3991 X-Ms-Office365-Filtering-Ht: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603142)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY4PR21MB0136; X-Ms-Traffictypediagnostic: CY4PR21MB0136: X-Exchange-Antispam-Report-Test: UriScan:(89211679590171)(9452136761055); X-Microsoft-Antispam-Prvs: X-Exchange-Antispam-Report-Cfa-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041248)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR21MB0136;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR21MB0136; X-Forefront-Prvs: 039975700A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(979002)(6009001)(39860400002)(47760400005)(13464003)(377454003)(199003)(189002)(54356999)(50986999)(76176999)(105586002)(6436002)(68736007)(102836003)(6116002)(66066001)(2501003)(3846002)(106356001)(6246003)(101416001)(53936002)(9686003)(99286003)(55016002)(5005710100001)(33656002)(229853002)(5660300001)(3280700002)(8936002)(2906002)(74316002)(77096006)(6506006)(8990500004)(7736002)(305945005)(1511001)(2950100002)(81156014)(81166006)(3660700001)(7696004)(8676002)(25786009)(97736004)(10090500001)(86362001)(2900100001)(53546010)(189998001)(86612001)(14454004)(10290500003)(478600001)(2201001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0136;H:CY4PR21MB0182.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-Spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ttalpey@microsoft.com; Spamdiagnosticoutput: 1:99 Spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Originatororg: microsoft.com X-Ms-Exchange-Crosstenant-Originalarrivaltime: 14 Aug 2017 21:20:01.7050 (UTC) X-Ms-Exchange-Crosstenant-Fromentityheader: Hosted X-Ms-Exchange-Crosstenant-ID: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-Ms-Exchange-Transport-Crosstenantheadersstamped: CY4PR21MB0136 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 22 Organization: linux.* mail to news gateway X-Original-Date: Mon, 14 Aug 2017 21:20:01 +0000 X-Original-Message-ID: X-Original-References: <1501704648-20159-1-git-send-email-longli@exchange.microsoft.com> <1501704648-20159-31-git-send-email-longli@exchange.microsoft.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1711475 > -----Original Message----- > From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs- > owner@vger.kernel.org] On Behalf Of Long Li > Sent: Wednesday, August 2, 2017 4:11 PM > To: Steve French ; linux-cifs@vger.kernel.org; samba- > technical@lists.samba.org; linux-kernel@vger.kernel.org > Cc: Long Li > Subject: [[PATCH v1] 30/37] [CIFS] SMBD: Add SMBDirect transport to Makef= ile >=20 > cifs-$(CONFIG_CIFS_SMB2) +=3D smb2ops.o smb2maperror.o smb2transport.o \ > - smb2misc.o smb2pdu.o smb2inode.o smb2file.o > + smb2misc.o smb2pdu.o smb2inode.o smb2file.o c= ifsrdma.o "cifsrdma.o" is a really confusing choice of names. SMB Direct is only possible when the negotiated SMB dialect is SMB3. "CIFS" historically means a dialect of SMB1, which many of us would like to see be in a separate, and therefore omittable, module. Please use a name more indicative of the function, perhaps "smbdirect.o". Tom.