RE: [[PATCH v1] 26/37] [CIFS] SMBD: Send an immediate packet when it's needed

From	Tom Talpey <ttalpey@microsoft.com>
Newsgroups	linux.kernel
Subject	RE: [[PATCH v1] 26/37] [CIFS] SMBD: Send an immediate packet when it's needed
Date	2017-08-14 23:20 +0200
Message-ID	<ueuWe-Mv-33@gated-at.bofh.it> (permalink)
References	<ua8hz-6jk-3@gated-at.bofh.it> <ua8hA-6jk-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs-
> owner@vger.kernel.org] On Behalf Of Long Li
> Sent: Wednesday, August 2, 2017 4:11 PM
> To: Steve French <sfrench@samba.org>; linux-cifs@vger.kernel.org; samba-
> technical@lists.samba.org; linux-kernel@vger.kernel.org
> Cc: Long Li <longli@microsoft.com>
> Subject: [[PATCH v1] 26/37] [CIFS] SMBD: Send an immediate packet when it's
> needed
> 
> +/*
> + * Check and schedule to send an immediate packet
> + * This is used to extend credtis to remote peer to keep the transport busy
> + */
> +static void check_and_send_immediate(struct cifs_rdma_info *info)
> +{
> +       info->send_immediate = true;
> +
> +       // promptly send a packet if running low on receive credits

...if *our peer* is running low on credits.

> +       if (atomic_read(&info->receive_credits) <
> +           atomic_read(&info->receive_credit_target) -1 )

Why read the receive_credit_target atomically? It's a mostly unchanging local value?

Tom.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: [[PATCH v1] 26/37] [CIFS] SMBD: Send an immediate packet when  it's needed Tom Talpey <ttalpey@microsoft.com> - 2017-08-14 23:20 +0200

csiph-web