Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1709890

Re: [PATCH] netfilter: nf_nat_h323: fix logical-not-parentheses warning

Show all headers | View raw

Hi Nick,

On Mon, Jul 31, 2017 at 11:39:49AM -0700, Nick Desaulniers wrote:
> Clang produces the following warning:
[...]
> Also, it's even cleaner to use the form:
> 
> if (x)
> 
> but then if the return codes change from treating 0 as success (unlikely),
> then all call sites must be updated.
> 
> I'm happy to send v2 that changes to that form, and updates the other call
> sites to be:
> 
> if (set_h225_addr())
>   handle_failures()
> else
>   handle_success()

That sounds very reasonable, send a v2 if this triggers a larger
patch.

Or I can just take this patch, as you prefer.

Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] netfilter: nf_nat_h323: fix logical-not-parentheses warning Nick Desaulniers <ndesaulniers@google.com> - 2017-07-31 20:50 +0200
  Re: [PATCH] netfilter: nf_nat_h323: fix logical-not-parentheses warning Nick Desaulniers <ndesaulniers@google.com> - 2017-08-09 01:30 +0200
  Re: [PATCH] netfilter: nf_nat_h323: fix logical-not-parentheses  warning Pablo Neira Ayuso <pablo@netfilter.org> - 2017-08-11 19:50 +0200
    [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning Nick Desaulniers <ndesaulniers@google.com> - 2017-08-11 20:20 +0200
      Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning Nick Desaulniers <ndesaulniers@google.com> - 2017-08-14 19:40 +0200
        Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning Nick Desaulniers <ndesaulniers@google.com> - 2017-08-24 18:30 +0200
        Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses  warning Pablo Neira Ayuso <pablo@netfilter.org> - 2017-08-24 19:00 +0200

csiph-web