Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1709748

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

Show all headers | View raw

Hi Phillip,

This patch is failing to apply on both v4.13-rc4 and linux-next:

error: patch failed: drivers/reset/reset-sunxi.c:108
error: drivers/reset/reset-sunxi.c: patch does not apply
Patch failed at 0001 reset: add reset-simple to unify socfpga, stm32,
sunxi, and zx2967


On 08/11/2017 08:06 AM, Philipp Zabel wrote:
> Split reusable parts out of the sunxi driver, to add a driver for simple
> reset controllers with reset lines that can be controlled by toggling
> bits in exclusive, contiguous register ranges using read-modify-write
> cycles under a spinlock. The separate sunxi driver still remains to
> register the early reset controllers, but it reuses the reset-simple
> ops.
> 
> The following patches will replace compatible reset drivers with
> reset-simple, extending it where necessary.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> Changes since v1:
> - Turn reset-simple into a complete platform driver.
> - Move common code out of assert and deassert ops into a helper function.
> - Add inverted flag to support both clear- and set-to-assert reset bits.
> - Remove status readback, will be added in the next patch.
> - Split out SoCFPGA and STM32 conversion into separate patches.
> ---

[snip]

> @@ -108,8 +55,9 @@ static int sunxi_reset_init(struct device_node *np)
>  
>  	data->rcdev.owner = THIS_MODULE;
>  	data->rcdev.nr_resets = size * 8;

I think the problem the above line. On both linux-next and v4.13-rc4:

data->rcdev.nr_resets = size * 32;

Dinh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967 Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-11 15:10 +0200
  Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32,  sunxi, and zx2967 Dinh Nguyen <dinguyen@kernel.org> - 2017-08-11 17:40 +0200
    Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32,  sunxi, and zx2967 Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-11 18:00 +0200
  Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32,  sunxi, and zx2967 Chen-Yu Tsai <wens@csie.org> - 2017-08-11 18:00 +0200
    Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32,  sunxi, and zx2967 Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-11 18:00 +0200
  Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32,  sunxi, and zx2967 Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-11 18:40 +0200
    Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32,  sunxi, and zx2967 Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2017-08-14 15:50 +0200
  Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32,  sunxi, and zx2967 Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-14 09:30 +0200

csiph-web