Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1710940
| From | Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967 |
| Date | 2017-08-14 15:50 +0200 |
| Message-ID | <uenUK-4MF-33@gated-at.bofh.it> (permalink) |
| References | <udhRo-3Vr-13@gated-at.bofh.it> <udhRo-3Vr-21@gated-at.bofh.it> <udl8B-5QR-15@gated-at.bofh.it> <udl8B-5QR-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Philipp,
On Fri, 2017-08-11 at 18:37 +0200, Philipp Zabel wrote:
> > > +struct reset_simple_devdata {
> > > > > + bool inverted;
> > >
> > > +};
> > > +
> > > +static const struct reset_simple_devdata reset_simple_inverted =
> > > {
> > > + .inverted = true,
> >
> > Hmm. I think it would be useful for new devices if there were have
> > a way
> > to specify this in devicetree.
>
> This is a separate issue, and it should be discussed including the
> device tree list.
>
> It could be as simple as a boolean "active-low;" property. But then
> absence of that property would not mean active-high for existing
> active-low drivers, which is confusing.
>
> It could also reuse the flags already defined in
> dt-bindings/reset/ti-syscon.h and have some kind of
> reset-flags = <ASSERT_SET | DEASSERT_CLEAR | STATUS_SET>;
> property.
>
> Suggestions welcome.
>
Imho,
reset-type = <ACTIVE_LOW | ACTIVE_HIGH>;
looks good.
--
Eugeniy Paltsev
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967 Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2017-08-14 15:50 +0200
csiph-web