Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1710208

[PATCH] watchdog: pcwd_usb: constify usb_device_id

Path csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] watchdog: pcwd_usb: constify usb_device_id
Date Sat, 12 Aug 2017 10:50:02 +0200
Message-ID <udAhk-6LC-5@gated-at.bofh.it> (permalink)
References <udA7I-6G3-111@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0Cv7IpXVnCN/MN71vNAxYwr2E0Bq5byVicuT1VrQY+A=; b=o4bfv9rzoOXTElQA50K9w5xm6kO52in4eXs5t5okj/iDYFpmDLqqSvb03fsfaeQ4GF rLtc/2ZPOpZ16WkZwiuCSCpt8gG3ohfkwRJI6tuyYfU7ic2gJhdvrbu13tsHiEYqwGxd HCZtHY9WJziLwHD4hUMFn8vRRCEK4WWa6JzKPF8MK4tBKOsfVmRjQlKwhZjtiMoqAYPP dfJ1ncWYz1q8EpYc1Jx40GWLrueMA/IBhWoa/8XNzK+npJ05lT/leN3QMOc2Pmtn6Qyp ZSVJ5HdMHSf81YSjU0KxNVWgLEIzVKIA9wfcfU5+gISr8pR4JNSwf0aANOP4m9YVuXV+ geTQ==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0Cv7IpXVnCN/MN71vNAxYwr2E0Bq5byVicuT1VrQY+A=; b=cI7qTWEVfWSQchIz0kUrbMhMsyRBp7Pm9waQzDG3wNX6pJwNH4e5VlbwEMD16DtIJ0 64oMHmtH1dWbyBgORhhR7zs92OftFZ64aimkuoFKDt/HftJNO2OfiMbPfBqnUPQoRE5C inUd2vrw0vl0AWPOS8LkYteMaA03utUlI+wI+AyKGNrZuKwRK+VAYTKIpUC68VHlHNcm m4wHY9Gi5HK11LXk+IZv5k2cOixG1yB68uAsukTdCqgRZchT4dye9VkdobXq1hTxWIhd 84VVdPGZBRpQBV/649QK2q62Ct+LQiTwHKnqP5RFjqXqptZ4EowrVaNgLvttcdi8tu4f PsxQ==
X-Gm-Message-State AHYfb5gtcuQ6ojbLBvp11aXf+8vly51RDwRg1eW+/Z4xTKWLzWITD3e+ Y/zEr9PlUUVOEw==
X-Received by 10.98.157.218 with SMTP id a87mr18666946pfk.208.1502527194973; Sat, 12 Aug 2017 01:39:54 -0700 (PDT)
X-Mailer git-send-email 2.7.4
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 24
Organization linux.* mail to news gateway
X-Original-Cc linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Sat, 12 Aug 2017 14:09:45 +0530
X-Original-Message-ID <137fce0c4bacbbd395cb56ee9360ae677e74e401.1502526524.git.arvind.yadav.cs@gmail.com>
X-Original-References <22fa8ca67a6d4a59997f463bf241ed56596fbcfa.1502526524.git.arvind.yadav.cs@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1710208

Show key headers only | View raw


usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/watchdog/pcwd_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/pcwd_usb.c b/drivers/watchdog/pcwd_usb.c
index 5615f40..b9e376c 100644
--- a/drivers/watchdog/pcwd_usb.c
+++ b/drivers/watchdog/pcwd_usb.c
@@ -74,7 +74,7 @@ MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default="
 #define USB_PCWD_PRODUCT_ID	0x1140
 
 /* table of devices that work with this driver */
-static struct usb_device_id usb_pcwd_table[] = {
+static const struct usb_device_id usb_pcwd_table[] = {
 	{ USB_DEVICE(USB_PCWD_VENDOR_ID, USB_PCWD_PRODUCT_ID) },
 	{ }					/* Terminating entry */
 };
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] drm: udl: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-12 10:40 +0200
  [PATCH] watchdog: pcwd_usb: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-12 10:50 +0200
    Re: [PATCH] watchdog: pcwd_usb: constify usb_device_id Guenter Roeck <linux@roeck-us.net> - 2017-08-14 16:50 +0200
  Re: [PATCH] drm: udl: constify usb_device_id Daniel Vetter <daniel@ffwll.ch> - 2017-08-14 16:20 +0200

csiph-web