Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1710985
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] watchdog: pcwd_usb: constify usb_device_id |
| Date | 2017-08-14 16:50 +0200 |
| Message-ID | <ueoQO-5lI-23@gated-at.bofh.it> (permalink) |
| References | <udA7I-6G3-111@gated-at.bofh.it> <udAhk-6LC-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Aug 12, 2017 at 02:09:45PM +0530, Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/pcwd_usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/pcwd_usb.c b/drivers/watchdog/pcwd_usb.c
> index 5615f40..b9e376c 100644
> --- a/drivers/watchdog/pcwd_usb.c
> +++ b/drivers/watchdog/pcwd_usb.c
> @@ -74,7 +74,7 @@ MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default="
> #define USB_PCWD_PRODUCT_ID 0x1140
>
> /* table of devices that work with this driver */
> -static struct usb_device_id usb_pcwd_table[] = {
> +static const struct usb_device_id usb_pcwd_table[] = {
> { USB_DEVICE(USB_PCWD_VENDOR_ID, USB_PCWD_PRODUCT_ID) },
> { } /* Terminating entry */
> };
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drm: udl: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-12 10:40 +0200
[PATCH] watchdog: pcwd_usb: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-12 10:50 +0200
Re: [PATCH] watchdog: pcwd_usb: constify usb_device_id Guenter Roeck <linux@roeck-us.net> - 2017-08-14 16:50 +0200
Re: [PATCH] drm: udl: constify usb_device_id Daniel Vetter <daniel@ffwll.ch> - 2017-08-14 16:20 +0200
csiph-web