Re: [PATCH] drm: udl: constify usb_device_id

From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm: udl: constify usb_device_id
Date	2017-08-14 16:20 +0200
Message-ID	<ueonM-5bN-25@gated-at.bofh.it> (permalink)
References	<udA7I-6G3-111@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Aug 12, 2017 at 02:05:19PM +0530, Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Applied, thanks.
-Daniel

> ---
>  drivers/gpu/drm/udl/udl_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c
> index cd8b017..2877afc 100644
> --- a/drivers/gpu/drm/udl/udl_drv.c
> +++ b/drivers/gpu/drm/udl/udl_drv.c
> @@ -118,7 +118,7 @@ static void udl_usb_disconnect(struct usb_interface *interface)
>   * which is compatible with all known USB 2.0 era graphics chips and firmware,
>   * but allows DisplayLink to increment those for any future incompatible chips
>   */
> -static struct usb_device_id id_table[] = {
> +static const struct usb_device_id id_table[] = {
>  	{.idVendor = 0x17e9, .bInterfaceClass = 0xff,
>  	 .bInterfaceSubClass = 0x00,
>  	 .bInterfaceProtocol = 0x00,
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm: udl: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-12 10:40 +0200
  [PATCH] watchdog: pcwd_usb: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-12 10:50 +0200
    Re: [PATCH] watchdog: pcwd_usb: constify usb_device_id Guenter Roeck <linux@roeck-us.net> - 2017-08-14 16:50 +0200
  Re: [PATCH] drm: udl: constify usb_device_id Daniel Vetter <daniel@ffwll.ch> - 2017-08-14 16:20 +0200

csiph-web