Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

From	Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control
Date	2017-08-11 06:30 +0200
Message-ID	<ud9K9-7dR-1@gated-at.bofh.it> (permalink)
References	<ucQ4O-2jh-13@gated-at.bofh.it> <ucQ4O-2jh-11@gated-at.bofh.it> <ucT2G-4pl-21@gated-at.bofh.it> <ucTFo-4RQ-17@gated-at.bofh.it> <ucTP3-4V8-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Yamada-san,

On 2017年08月10日 20:23, Masahiro Yamada wrote:
> Hi.
> 
> 
> 2017-08-10 20:11 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
>> 2017-08-10 19:37 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
>>> Hi Katsuhiro,
>>>
>>> On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:
>>>> Add a reset line for analog signal amplifier core (ADAMV) on
>>>> UniPhier LD11/LD20 SoCs.
>>>>
>>>>> Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
>>>> ---
>>>>   drivers/reset/reset-uniphier.c | 15 +++++++++++++++
>>>>   1 file changed, 15 insertions(+)
>>>>
>>>> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
>>>> index f60c137c17cb..cda4a78a58e2 100644
>>>> --- a/drivers/reset/reset-uniphier.c
>>>> +++ b/drivers/reset/reset-uniphier.c
>>>> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data uniphier_pro4_peri_reset_data[] = {
>>>>>      UNIPHIER_RESET_END,
>>>>   };
>>>>
>>>> +/* Analog signal amplifiers reset data */
>>>> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {
>>>>> +   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
>>>>> +   UNIPHIER_RESET_END,
>>>> +};
> 
> 
> I take back my Acked-by.
> 
> 
> The reset line index is independent from others
> because this block is a separate instance.
> 
> Are you OK with starting from the reset ID 100?

It's my mistake. This ID can start with 0.
I will fix in next V2 series, thank you.

Regards,
--
Katsuhiro Suzuki

Thread

[PATCH 3/3] reset: uniphier: add analog amplifiers reset control Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com> - 2017-08-10 09:30 +0200
  Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-10 12:40 +0200
    Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-10 13:20 +0200
      Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-10 13:30 +0200
        Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com> - 2017-08-11 06:30 +0200
    Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com> - 2017-08-11 07:00 +0200

csiph-web