Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1708407

Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

From Philipp Zabel <p.zabel@pengutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control
Date 2017-08-10 12:40 +0200
Message-ID <ucT2G-4pl-21@gated-at.bofh.it> (permalink)
References <ucQ4O-2jh-13@gated-at.bofh.it> <ucQ4O-2jh-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Katsuhiro,

On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:
> Add a reset line for analog signal amplifier core (ADAMV) on
> UniPhier LD11/LD20 SoCs.
> 
> > Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
> ---
>  drivers/reset/reset-uniphier.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
> index f60c137c17cb..cda4a78a58e2 100644
> --- a/drivers/reset/reset-uniphier.c
> +++ b/drivers/reset/reset-uniphier.c
> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data uniphier_pro4_peri_reset_data[] = {
> >  	UNIPHIER_RESET_END,
>  };
>  
> +/* Analog signal amplifiers reset data */
> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {
> > +	UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
> > +	UNIPHIER_RESET_END,
> +};
> +
>  /* core implementaton */
>  struct uniphier_reset_priv {
> >  	struct reset_controller_dev rcdev;
> @@ -415,6 +421,15 @@ static const struct of_device_id uniphier_reset_match[] = {
> >  		.compatible = "socionext,uniphier-ld20-peri-reset",
> >  		.data = uniphier_pro4_peri_reset_data,
> >  	},
> > +	/* Analog signal amplifiers reset */
> > +	{
> > +		.compatible = "socionext,uniphier-ld11-adamv-reset",
> > +		.data = uniphier_ld11_adamv_reset_data,
> > +	},
> > +	{
> > +		.compatible = "socionext,uniphier-ld20-adamv-reset",
> > +		.data = uniphier_ld11_adamv_reset_data,
> > +	},
> >  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, uniphier_reset_match);

Please add a patch to describe the new compatible values in
Documentation/devicetree/bindings/reset/uniphier-reset.txt.

regards
Philipp

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 3/3] reset: uniphier: add analog amplifiers reset control Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com> - 2017-08-10 09:30 +0200
  Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-10 12:40 +0200
    Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-10 13:20 +0200
      Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-10 13:30 +0200
        Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com> - 2017-08-11 06:30 +0200
    Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com> - 2017-08-11 07:00 +0200

csiph-web