Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1709171
| From | Honghui Zhang <honghui.zhang@mediatek.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RESEND PATCH 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding |
| Date | 2017-08-11 04:20 +0200 |
| Message-ID | <ud7Im-5Zt-3@gated-at.bofh.it> (permalink) |
| References | <ucLot-7NK-3@gated-at.bofh.it> <ucLot-7NK-5@gated-at.bofh.it> <ucQRc-2OS-17@gated-at.bofh.it> <ud75D-5qQ-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 2017-08-11 at 09:37 +0800, Jun Gao wrote: > On Thu, 2017-08-10 at 16:19 +0800, Honghui Zhang wrote: > > On Thu, 2017-08-10 at 10:27 +0800, Jun Gao wrote: > > > From: Jun Gao <jun.gao@mediatek.com> > > > > > > Add MT7622 i2c binding to binding file. Compare to MT8173 i2c > > > controller, MT7622 limits message numbers to 255, and does not > > > support 4GB DMA mode. > > > > > > Signed-off-by: Jun Gao <jun.gao@mediatek.com> > > > --- > > > Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++----- > > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > > > index bd5a7be..ff9ac61 100644 > > > --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > > > +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > > > @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices. > > > > > > Required properties: > > > - compatible: value should be either of the following. > > > - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701 > > > - "mediatek,mt6577-i2c": for i2c compatible with mt6577. > > > - "mediatek,mt6589-i2c": for i2c compatible with mt6589. > > > - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623. > > > - "mediatek,mt8173-i2c": for i2c compatible with mt8173. > > > + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701 > > > + "mediatek,mt6577-i2c": for Mediatek MT6577 > > > + "mediatek,mt6589-i2c": for Mediatek MT6589 > > > > Better not change those and just add compatible strings for mt7622. > > > It seems better to use the same format for all SoCs. > Alright, do you need to put those changes in commit message? Thanks. > Jun > > > + "mediatek,mt7622-i2c": for Mediatek MT7622 > > > + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623 > > > + "mediatek,mt8173-i2c": for Mediatek MT8173 > > > - reg: physical base address of the controller and dma base, length of memory > > > mapped region. > > > - interrupts: interrupt number to the cpu. > > > > > >
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[RESEND PATCH 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding Jun Gao <jun.gao@mediatek.com> - 2017-08-10 04:30 +0200
Re: [RESEND PATCH 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding Honghui Zhang <honghui.zhang@mediatek.com> - 2017-08-10 10:20 +0200
Re: [RESEND PATCH 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding Jun Gao <jun.gao@mediatek.com> - 2017-08-11 03:40 +0200
Re: [RESEND PATCH 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding Honghui Zhang <honghui.zhang@mediatek.com> - 2017-08-11 04:20 +0200
csiph-web