Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1709172

Re: [PATCH v5 3/5] btrfs: Add zstd support

Show all headers | View raw

On Wed, Aug 09, 2017 at 07:39:02PM -0700, Nick Terrell wrote:
> Add zstd compression and decompression support to BtrFS.

Re-tested on arm64, amd64 and i386, this time everything seems fine so far.

As I'm too lazy to have a separate test setup for the zlib level patch,
I'm using a dummy implementation:

--- a/fs/btrfs/zstd.c
+++ b/fs/btrfs/zstd.c
@@ -423,10 +423,16 @@ static int zstd_decompress(struct list_head *ws, unsigned char *data_in,
        return ret;
 }
 
+static void zstd_set_level(struct list_head *ws, unsigned int type)
+{
+       // TODO
+}
+
 const struct btrfs_compress_op btrfs_zstd_compress = {
        .alloc_workspace = zstd_alloc_workspace,
        .free_workspace = zstd_free_workspace,
        .compress_pages = zstd_compress_pages,
        .decompress_bio = zstd_decompress_bio,
        .decompress = zstd_decompress,
+       .set_level = zstd_set_level,
 };


It might be worthwhile to do some early testing using different levels,
though.


喵!
-- 
⢀⣴⠾⠻⢶⣦⠀ 
⣾⠁⢠⠒⠀⣿⡁ A dumb species has no way to open a tuna can.
⢿⡄⠘⠷⠚⠋⠀ A smart species invents a can opener.
⠈⠳⣄⠀⠀⠀⠀ A master species delegates.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 3/5] btrfs: Add zstd support Nick Terrell <terrelln@fb.com> - 2017-08-10 04:40 +0200
  Re: [PATCH v5 3/5] btrfs: Add zstd support Adam Borowski <kilobyte@angband.pl> - 2017-08-11 04:20 +0200
    Re: [PATCH v5 3/5] btrfs: Add zstd support Nick Terrell <terrelln@fb.com> - 2017-08-11 05:30 +0200
  Re: [PATCH v5 3/5] btrfs: Add zstd support "Austin S. Hemmelgarn" <ahferroin7@gmail.com> - 2017-08-11 13:50 +0200

csiph-web